Opened 3 years ago

Closed 3 years ago

#21292 closed defect (fixed)

table elements should not have cellspacing or cellpadding

Reported by: irl Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #21274 Points:
Reviewer: Sponsor:

Description

Both of these attributes are deprecated and the desired effects should be sought using CSS instead. These can be found on the search results page.

Child Tickets

Change History (6)

comment:1 Changed 3 years ago by irl

Removing these makes it basically clean on the W3C validator, but there still seems to be some issue regarding the ordering of the thead, tfoot and tbody tags within the DOM. They're correct as W3C sees it in the template, but the Mozilla docs disagree afaict. Needs some investigating...

comment:2 Changed 3 years ago by irl

Owner: changed from irl to RaBe
Status: newassigned

Patch for this is at:

https://gitweb.torproject.org/user/irl/atlas.git/patch/?id=d0704a1c0aa03ed385f0224394aa3fcda39eabb7

The remaining issue on the search page (Element tbody not allowed as child of element table in this context) is a result of a bug in Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=272267), the behavior in Atlas is correct according to the HTML 5.2 Spec and the most recent changelog in the W3C validator (https://github.com/validator/validator/blob/8fe5e1369860fcbc7ba798c0b40eb3b80ab3beec/WHATSNEW.md).

Ready for review. (:

comment:3 Changed 3 years ago by irl

Status: assignedneeds_review

comment:4 Changed 3 years ago by RaBe

Owner: changed from RaBe to irl
Status: needs_reviewassigned

Great :)

comment:5 Changed 3 years ago by RaBe

Status: assignedmerge_ready

comment:6 Changed 3 years ago by irl

Resolution: fixed
Status: merge_readyclosed

Thanks, merged.

Note: See TracTickets for help on using tickets.