#21294 closed defect (fixed)

Exits don't allow single-hop SOCKSPorts - update single onion man page

Reported by: teor Owned by: dgoulet
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.1-alpha
Severity: Normal Keywords: doc, tor-hs, single-onion
Cc: Actual Points:
Parent ID: Points: 0.2
Reviewer: Sponsor:

Description

The single onion service manual page entries encourage users to use Tor2Web when opening a SOCKSPort on a tor in single onion service mode.

But this SOCKSPort will only work as a hidden service client, and not an exit client, because exits block single-hop circuits.

So we should fix the log message and the docs to avoid mentioning Tor2Web mode as an alternative. (But I think we can keep the code as-is, it will work for the hidden service client case, but not the Exit case.)

Child Tickets

Change History (11)

comment:1 Changed 10 months ago by dgoulet

Owner: set to dgoulet
Status: newaccepted

comment:2 Changed 10 months ago by dgoulet

Status: acceptedneeds_information

I'm quite confused here. SOCKSPort is completely disabled on a tor running Single Onion Service so what this ticket is actually addressing?

And, I don't see in the man page where we encourage users to use Tor2Web with single onion?

The only thing I can find is this log message:

    REJECT("HiddenServiceNonAnonymousMode is incompatible with using Tor as "
           "an anonymous client. Please set Socks/Trans/NATD/DNSPort to 0, or "
           "HiddenServiceNonAnonymousMode to 0, or use the non-anonymous "
           "Tor2webMode.");

And also, man page specifies for the Tor2Web option:

This option also disables client connections to non-hidden-service hostnames through Tor.

To recap, only fixing the log message seems the right thing to do? (Apart from ripping off Tor2Web madness :P).

comment:3 Changed 10 months ago by dgoulet

Scratch that, if Tor2web is enabled with non anonymous mode, SocksPort is allowed.

comment:4 Changed 10 months ago by dgoulet

Status: needs_informationneeds_review

Ok an attempt: bug21294_030_01.

Basically, the only thing it does is change that log message to NOT recommend Tor2web.

comment:5 Changed 10 months ago by nickm

looks fine but needs a changes file. (yes, I know it's small, but people should know this.)

comment:6 Changed 10 months ago by dgoulet

I almost got away with it! :P

Fixup commit e535e23.

comment:7 Changed 10 months ago by teor

Status: needs_reviewmerge_ready

Looks good to me, thanks!

comment:8 Changed 10 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

comment:9 Changed 10 months ago by dgoulet

Resolution: fixed
Status: closedreopened

My bad, we broke the unit test expected log message.

See branch bug21294_030_02, top commit fixes that.

comment:10 Changed 10 months ago by dgoulet

Status: reopenedmerge_ready

comment:11 Changed 10 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged that too!

Note: See TracTickets for help on using tickets.