Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#21324 closed enhancement (fixed)

Don't update NoScript button every 24 minutes

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, TorBrowserTeam201701R
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Every 24 minutes we update the NoScript button according to the messages in my terminal looking like

Torbutton INFO: Updated NoScript status for security settings

This is done by calling torbutton_update_noscript_button();. The call is triggered by

if (data.startsWith("noscript.")) {
  torbutton_update_noscript_button();
}

in our preference observer. It turns out there is a timer update happening every 24 minutes which gets saved in noscript.subscription.lastCheck. This is harmless for us as there are no subscription URLs available but nevertheless excessive.

This got first mentioned in our blog: https://blog.torproject.org/blog/tor-browser-70a1-released#comment-232575

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201701R added
Status: newneeds_review

comment:2 Changed 3 years ago by mcs

r=brade, r=mcs
You should fix the typo in the comment: "show" should be "shows" in "Make sure the NoScript button show..."

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. Fix and applied to master with commit 8bc9aef5b873eecdae32a34f69170006c31eeddc.

comment:4 Changed 2 years ago by cypherpunks

Maybe, just set noscript.subscription.checkInterval

"subscription.checkInterval":24,

to -1?

Note: See TracTickets for help on using tickets.