Non-usable scrollbar appears in tor browser security settings

empty white space in tor browser security settings, open security settings and set it to high and close security settings and reopen it. This should cause the bug. I made a video showing the bug. tor browser 6.5

Trac:
Username: Dbryrtfbcbhgf

added TorBrowserTeam201701R component::applications/tor browser owner::tbb-team priority::medium reporter::Dbryrtfbcbhgf resolution::fixed severity::normal status::closed tbb-6.5-regression tbb-security-slider tbb-usability type::defect labels

Replying to Dbryrtfbcbhgf:

empty white space in tor browser security settings, open security settings and set it to high and close security settings and reopen it. This should cause the bug. I made a video showing the bug. tor browser 6.5 Here is the video. http://sendvid.com/rzzvo8dt

Trac:
Username: Dbryrtfbcbhgf

FWICT that white space is a disabled scrollbar.

I can reproduce that on my Linux box with "Medium" it seems.

Trac:
Keywords: N/A deleted, tbb-usability, tbb-security-slider, tbb-6.5-regression added
Summary: empty white space in tor browser security settings to Non-usable scrollbar appears in tor browser security settings

Trac:
Cc: N/A to arthuredelstein

I can reproduce this if I change "Show scrollbars" in my OSX System Preferences to "Always."

Kathy and I will try to debug this problem (unless someone else is already working on it).

Trac:
Cc: arthuredelstein to arthuredelstein, brade, mcs

This seems to be a XUL bug. Here is a workaround: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug21330-01&id=be72f95ae3b787c063e65afeeeb24646ef416fe0

We tested on Win7, OSX 10.11.6, and Ubuntu 14.04 LTS (before making this fix, we were able to reproduce this "phantom scrollbar" problem on all 3 platforms when the Security Settings window was sized 'just right').

Trac:
Keywords: N/A deleted, TorBrowserTeam201701R added
Status: new to needs_review

Replying to mcs:

This seems to be a XUL bug. Here is a workaround:

Do you think it is worth filing one in bugzilla and if so, could you do that?

Replying to mcs:

This seems to be a XUL bug. Here is a workaround: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug21330-01&id=be72f95ae3b787c063e65afeeeb24646ef416fe0

Looks good to me. Could you elaborate on the role the return false; statement plays in this patch? We need this to fix the scrollbar problem?

Trac:
Status: needs_review to needs_information

Replying to gk:

Replying to mcs:

This seems to be a XUL bug. Here is a workaround:

Do you think it is worth filing one in bugzilla and if so, could you do that?

Maybe, although I don't think it is worth filing one unless we come up with a small reproducible test case. Should we spend time on that or not?

Replying to gk:

Looks good to me. Could you elaborate on the role the return false; statement plays in this patch? We need this to fix the scrollbar problem?

That should not be there. It is left over from some debugging we did to find the workaround. I will remove it and provide a new patch. Sorry!

Here is a revised patch: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug21330-02

Trac:
Status: needs_information to needs_review

Replying to mcs:

Replying to gk:

Replying to mcs:

This seems to be a XUL bug. Here is a workaround:

Do you think it is worth filing one in bugzilla and if so, could you do that?

Maybe, although I don't think it is worth filing one unless we come up with a small reproducible test case. Should we spend time on that or not?

Mmmh... And we would make sure it is still an issue in recent nightlies. So, no, I think we can live with that without filing a bug or investigating this closer.

That said I merged your -02 fix to master and cherry-picked it to maint-1.9.6 (commits 9c4a20bec5d1f3fc38a103b4f47c1039f48119dd and 2a311617e1045cf5316fdab9aea1df9b1c7d02d4), thanks.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#21330 (closed)