Opened 3 years ago

Closed 3 years ago

#21343 closed defect (fixed)

Remove unused FTE related parts on the macOS Gitian descriptors

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-gitian, TorBrowserTeam201701R
Cc: mcs, brade, kpdyer, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We disabled FTE packaging in #13252 due to code-signing issues. No progress has made on this issue (tracked in #18495) since. We should back out the FTE part and all the related Python parts and building GMP as both are only needed for FTE. This would simplify our descriptors considerably and would avoid building stuff we don't need and would make it easier to migrate to a rbm based build system. Once #18495 got resolved we can include FTE for macOS again.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by gk

Keywords: TorBrowserTeam201701R added
Status: newneeds_review

See bug_21343_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21343_v2&id=aac2599627dbb1073c45bb056582db01a833b7a4) in my public tor-browser-bundle repo for a patch up for review. I've tested the fix and am still able to use obfs4 et al. and meek.

comment:2 Changed 3 years ago by mcs

r=mcs
Looks good to me. I did not try a build, but if somehow there is a problem that you did not notice we will probably find it soon enough.

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

I guess so, yes. This is commit fc71d02f70b8bd05fbd4cd09650b175ea29fe186 on master.

Note: See TracTickets for help on using tickets.