Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#21348 closed defect (fixed)

Snowflake is selectable on non-Linux platforms

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201701R snowflake
Cc: mcs, brade, arlolra Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

We provide a working snowflake implementation only for Linux bundles right now. However, it is included in Tor Launcher's drop-down PT list on non-Linux platforms as well.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by gk

Cc: arlolra added
Keywords: TorBrowserTeam201701R added
Status: newneeds_review

comment:2 Changed 3 years ago by cypherpunks

There is a small typo in the comments (s/Linx/Linux/).

Last edited 3 years ago by cypherpunks (previous) (diff)

comment:4 Changed 3 years ago by mcs

Status: needs_reviewneeds_revision

In mkbundle-windows.sh, we need to remove this line (right after the lines you added):

cp PTConfigs/bridge_prefs.js $GITIAN_DIR/inputs/

comment:5 Changed 3 years ago by gk

Status: needs_revisionneeds_review

It turns out there is no need either to touch the torrc-defaults-appendix file for macOS users (in case one ships with the new layout). I reverted that change I made mistakenly as well. Now it is bug_21348_v4 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21348_v4&id=3da7562b247f95a233acb85a51c87bc45f807c95).

comment:6 Changed 3 years ago by mcs

r=mcs
Looks good to me now (I did not test it, but I trust you).

comment:7 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, this is commit ff0756e4778736cb2e05f260bf277c20bcd2d31a on master now. (FWIW: I tested it by comparing the resulting bridge_prefs.js files after doing the various grep calls)

comment:8 Changed 2 years ago by dcf

Keywords: snowflake added
Note: See TracTickets for help on using tickets.