Opened 9 years ago

Closed 8 years ago

#2135 closed defect (fixed)

Generalize Vidalia's configuration for Firefox

Reported by: erinn Owned by: chiiph
Priority: Medium Milestone: Vidalia: 0.3.x
Component: Archived/Vidalia Version: Vidalia 0.2.10
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Once upon a time there was a single Tor Browser Bundle for Windows, but now we also support OS X and Linux, and Vidalia has to be patched in order to handle TBBs that aren't Windows. It has some hardcoded paths that were originally setup in order to better handle Firefox Portable's directory structure, but these don't apply to Linux or OS X, and probably won't apply to Windows either when I start building Firefox for all of the platforms. (I currently do this for OS X and x86_64.)

You can see how this is handled by default in src/vidalia/MainWindow.cpp at:
590: MainWindow::launchBrowserFromDirectory()

In my ideal world, I would just give the full path in vidalia.conf without having to patch that file or create strange directory structures in order to obey it.

I've also attached a diff between the default MainWindow.cpp and the patched version used on OS X.

Child Tickets

Attachments (1)

vidalia-osx.diff (3.0 KB) - added by erinn 9 years ago.

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by erinn

Attachment: vidalia-osx.diff added

comment:1 Changed 9 years ago by chiiph

If just adding the proper variables in vidalia.conf will ease your work, from the diff it seems to be pretty simple to accomplish. In fact, we can have different defaults in the configuration depending on the platform the code is built.
How does that sound?

comment:2 Changed 9 years ago by edmanm

Why does your patch also revert my fix for ticket #610 from Vidalia's bug tracker (the one about having an empty menubar icon on OS X)?

comment:3 Changed 8 years ago by chiiph

Milestone: Vidalia-0.3.X

comment:4 Changed 8 years ago by chiiph

Resolution: fixed
Status: newclosed

The plugin system is already working, and the tbb plugin can be improved without having to change Vidalia, so I'm cosidering this fixed.

Note: See TracTickets for help on using tickets.