Opened 3 years ago

Closed 3 years ago

#21352 closed defect (fixed)

Legends in graphs seem to upset the W3C validator

Reported by: irl Owned by: irl
Priority: Low Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #21274 Points:
Reviewer: Sponsor:

Description

The validator seems to be happy with the SVGs as far as the legends, and then finds that elements appear where they shouldn't. The first error occurs on a g element with a class of "legend":

<g y="25" x="415" class="legend">

"Attribute y not allowed on element g at this point."

Not sure if this is a validator bug, or if this is a bug in our graphing library, or a bug in Atlas.

Child Tickets

Attachments (1)

0001-Remove-disallowed-element-attributes.patch (1.4 KB) - added by cypherpunks 3 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 3 years ago by cypherpunks

This is a bug in Atlas. The MDN documentation of the <g> tag doesn't indicate the y or x attributes are okay to use. Removing the attributes shows no difference.

The validator also complains about the height and width attributes on the text tag. Once again the MDN documentation doesn't indicate these are okay to use and show no difference when removed.

Patch is coming after some more testing.

Changed 3 years ago by cypherpunks

comment:2 Changed 3 years ago by cypherpunks

Status: newneeds_review

I've attached a patch that removes the aforementioned attributes.

comment:3 Changed 3 years ago by irl

Resolution: fixed
Status: needs_reviewclosed

Awesome! Thanks for your work on this. Merged. (:

Note: See TracTickets for help on using tickets.