Investigate whether descriptor parsing is guaranteed to be thread-safe

Partially discovered in #20440 (moved) and should be thoroughly verified. Class affected BlockingIteratorImpl

added component::metrics/library metrics-2018 owner::metrics-team priority::medium resolution::fixed severity::normal status::closed type::task labels

I'm unclear what makes you think that metrics-lib is not thread-safe. I mean, this could be the case. But the issue in #20440 (moved) did not indicate problems with thread-safety, did it? Can you give more details?

My investigations back than for #20440 (moved) made me aware of this.

I'll device a test for (re)producing the concurrency issues in BlockingIteratorImpl.

Setting to needs_information until there's a way to reproduce this issue.

Trac:
Summary: metrics-lib might not be thread save to metrics-lib might not be thread-safe
Status: new to needs_information

Trac:
Milestone: N/A to metrics-lib 1.8.0
Type: defect to task

This is potentially a hidden major bug, but it seems like it won't be relevant until we get to #21751 (moved). And we likely won't get to that before 2.1.0 for which we don't have a milestone yet. Unassigning from milestones until we make new plans. (The same goes for #21751 (moved).)

Trac:
Milestone: metrics-lib 1.8.0 to N/A

Note: Also look into #22678 (moved) when working on this.

Tweak summary a bit.

Trac:
Summary: metrics-lib might not be thread-safe to Investigate whether descriptor parsing is guaranteed to be thread-safe

Trac:
Keywords: N/A deleted, metrics-2018 added

Trac:
Keywords: metrics-2018 deleted, metrics-2017 added

Will be completed in 2018.

Trac:
Keywords: metrics-2017 deleted, metrics-2018 added

Waiting on the solution to #20395 (moved).

Trac:
Owner: metrics-team to iwakeh
Status: needs_information to accepted

Adding metrics-team to cc

Trac:
Cc: N/A to metrics-team

Won't be starting work on this next week. -> re-assigning to metrics-team.

Trac:
Status: accepted to assigned
Owner: iwakeh to metrics-team

We started parsing descriptors with multiple threads for #31204 (moved) which we deployed 2 months ago. In that context we discovered and fixed #32194 (moved). We have been parsing many, many descriptors in parallel since then. We didn't find anything else. I'd say it's safe to assume that there are either no more issues with thread-safety or that they're really hard to trigger. I also took a quick look at the metrics-lib code to see if there are similar bugs like #32194 (moved), but didn't find anything. Investigation concluded. Closing.

Trac:
Status: assigned to closed
Resolution: N/A to fixed

closed

mentioned in issue #21751 (moved)

mentioned in issue #22678 (moved)