Opened 10 months ago

Closed 26 hours ago

#21368 closed enhancement (fixed)

Add number of effective family members to search output page

Reported by: cypherpunks Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

use case:
I regularly reach out [1] to tor relay operators running potentially dangerous relay groups [2] and include a table that shows them their relays with the effective number of relays in their family per relay.
This makes it easy to spot on which relay they forgot the MyFamily setting in their torrc.

Note: The number of effective family members should always include the relay itself no matter whether it was explicitly listed or not.

The goal is to simply make sure that the amount of relays matches the amount of effective family members (=proper MyFamily setup).

Instead of adding a table in the email:
example:

+------------+---------------+----------------+
| first_seen | IP            | eMyFamilyCount |
+------------+---------------+----------------+
| 2017-01-03 | 217.12.199.87 |              2 |
| 2017-01-05 | 5.2.75.203    |           NULL |
| 2017-01-05 | 149.56.1.204  |           NULL |
| 2017-01-05 | 185.106.103.5 |              2 |
+------------+---------------+----------------+

It would be greate if I could simply include an atlas link:
https://atlas.torproject.org/#search/contact:Chauhan

and they get the same info.

The entire use case depends also on #21366.

[1] https://lists.torproject.org/pipermail/tor-relays/2017-January/011576.html
[2] https://raw.githubusercontent.com/ornetstats/stats/master/o/potentially_dangerous_relaygroups.txt

Child Tickets

Attachments (2)

0001-Add-the-effective-family-count-to-the-search-page.patch (1.2 KB) - added by cypherpunks 6 months ago.
0002-Add-the-relay-to-its-own-effective-family.patch (2.2 KB) - added by cypherpunks 6 months ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 months ago by cypherpunks

Including the relay itself into the effective family member count makes sense for the aforementioned goal. However, i imagine this is confusing when users view the details page and don't see the same number of lines in the effective family members section.

A solution would be to add the relay fingerprint to the effective family member section (possibly with a suffix stating this is the relay itself), but duplicates information because the same fingerprint is already shown at the top of the properties column.

comment:2 in reply to:  1 Changed 6 months ago by cypherpunks

Replying to cypherpunks:

A solution would be to add the relay fingerprint to the effective family member section (possibly with a suffix stating this is the relay itself), but duplicates information because the same fingerprint is already shown at the top of the properties column.

Thinking about this again i believe the information duplication is not worth blocking this ticket for. Patch 0002-Add-the-relay-to-its-own-effective-family.patch adds the relay fingerprint to the effective family member list and appends the tooltip to mention this change.

comment:3 Changed 6 months ago by cypherpunks

Status: newneeds_review

comment:4 Changed 4 months ago by irl

I think this is fine if we don't add 1. I'm sure you can just mentally add the 1 for your use case, it's not going to cause discrepancies for you in your use of the number, they'll all just be one less than you're used to.

comment:5 Changed 4 months ago by irl

Status: needs_reviewneeds_revision

comment:6 Changed 2 months ago by karsten

Summary: add number of effective family members to search output pageAdd number of effective family members to search output page

Capitalize summary.

comment:7 Changed 8 weeks ago by karsten

Owner: changed from irl to metrics-team
Status: needs_revisionassigned

comment:8 Changed 26 hours ago by irl

Resolution: fixed
Status: assignedclosed

Fixed in 4f1d496.

Note: See TracTickets for help on using tickets.