Opened 21 months ago

Last modified 3 months ago

#21377 accepted enhancement

DirAuths should expose bwauth bandwidth files

Reported by: tom Owned by: juga
Priority: High Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-dirauth, metrics, tor-bwauth, 035-removed-20180711, 035-roadmap-proposed
Cc: teor Actual Points:
Parent ID: #25925 Points:
Reviewer: Sponsor:

Description

Currently, DirAuths that vote on bwauth files do not expose the raw voting file they used. This data would be good to archive for debugging and transparency purposes.

Child Tickets

TicketTypeStatusOwnerSummary
#26694enhancementclosedjugadir-spec: DirAuths should expose bwauth bandwidth files
#26797defectnewDirAuths should only read the V3BandwidthsFile once per vote
#26904tasknewWork out if we need to round scanner measured bandwidths to protect individual client usage

Change History (17)

comment:1 Changed 21 months ago by tom

The ticket blocks archiving the data in collector, #21378

comment:2 Changed 21 months ago by asn

Keywords: tor-dirauth metrics added
Milestone: Tor: unspecified

comment:3 Changed 15 months ago by nickm

Priority: LowHigh

comment:4 Changed 4 months ago by juga

This is now fixed in sbws, though is still not being use by any DirAuth.

It is not planned to add this to Torflow.

comment:5 Changed 4 months ago by juga

Keywords: tor-bwauth added

comment:6 Changed 4 months ago by juga

Cc: teor added

comment:7 in reply to:  4 Changed 4 months ago by teor

Summary: DirAuths should expose bwauth votesDirAuths should expose bwauth bandwidth files

Replying to juga:

This is now fixed in sbws, though is still not being use by any DirAuth.

It is not planned to add this to Torflow.

This ticket is about archiving exposing the entire v3bw file, not just the headers.

Can you explain how this is fixed in sbws?

Last edited 4 months ago by teor (previous) (diff)

comment:8 Changed 4 months ago by juga

My mistake, didn't re-read the title of the ticket.
No, sbws does not fix this.

comment:9 Changed 3 months ago by juga

Changes to dir-spec commented https://trac.torproject.org/projects/tor/ticket/21378#comment:7 implemented in my branch.
Please let me know if i should create a different ticket for the spec.

Edit: correct url to the comment

Last edited 3 months ago by juga (previous) (diff)

comment:10 Changed 3 months ago by juga

Status: newneeds_review

comment:11 in reply to:  9 Changed 3 months ago by teor

Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Status: needs_reviewneeds_revision

Replying to juga:

Changes to dir-spec commented https://trac.torproject.org/projects/tor/ticket/21378#comment:7 implemented in my branch.

I think the pull request is:
https://github.com/torproject/torspec/pull/21

In future, please link to the branch or pull request, so I know which one you want me to review.

Please let me know if i should create a different ticket for the spec.

Yes, please open a different ticket, otherwise this ticket will close when we merge the spec.

Please see my comments on the pull request.

comment:12 Changed 3 months ago by juga

Created #26694 for the spec changes.

comment:13 Changed 3 months ago by teor

Parent ID: #25925

comment:14 Changed 3 months ago by juga

Owner: set to juga
Status: needs_revisionaccepted

Changing status since the ticket for the spec is #26694

comment:15 Changed 3 months ago by nickm

Keywords: 035-removed-20180711 added
Milestone: Tor: 0.3.5.x-finalTor: unspecified

These tickets are being triaged out of 0.3.5. The ones marked "035-roadmap-proposed" may return.

comment:16 Changed 3 months ago by teor

Keywords: 035-roadmap-proposed added

We would like to implement this ticket in 0.3.5, but we want a working bandwidth scanner first.

comment:17 Changed 3 months ago by teor

The refactor in #26797 will involve storing a copy of the bandwidth file in RAM or on disk, so let's do it first.

Note: See TracTickets for help on using tickets.