Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#21384 closed enhancement (fixed)

Add a graph on Tor Browser downloads by platform

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


We have been asked on the blog to provide another graph on Tor Browser downloads by platform, and I agree that this graph can be useful. I'll provide a branch as soon as I have a ticket number.

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by karsten

Status: newneeds_review

Please review this patch.

comment:2 Changed 4 years ago by iwakeh

Is there a preview available?

Regarding the R code my previous comments apply.
The function definition for formatter appears six times now in graphs.R and all these are identical.
Maybe make it one?

There is an explanation for the values of 'platform' already, but I would assume that with this new graph people will have questions about what it means exactly. Should a sentence be added to the graphs explanation and/or the description? Like, the os-type is only inferred from the request string or similar?

comment:3 Changed 4 years ago by karsten

Please review the two new commits in my earlier branch, and please take a look the preview here:

comment:4 Changed 4 years ago by iwakeh

Status: needs_reviewmerge_ready

Looks fine and the descriptions read well to me.
Merge ready.

comment:5 Changed 4 years ago by karsten

Resolution: fixed
Status: merge_readyclosed

Great! Merged, closing. Thanks!

comment:6 Changed 4 years ago by cypherpunks

Since I was confused how you could possibly know the platform of the OS doing the download because you do not store user agent strings in logs.

Maybe you want to make it even more obvious in the explanation:
"This graph does NOT show the OS used to download torbrowser, but it shows for which operating system the binary has been fetched for"

(or similar)

comment:7 Changed 4 years ago by karsten

Tweaked the text a bit.

Note: See TracTickets for help on using tickets.