Opened 2 years ago

Closed 20 months ago

#21393 closed defect (fixed)

bwauths use FastFirstHopPK, which is deprecated.

Reported by: Sebastian Owned by: tom
Priority: Medium Milestone:
Component: Core Tor/Torflow Version:
Severity: Normal Keywords: tor-dirauth try-and-find-out deprecated
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:

Description

It's a deprecated option scheduled for removal, but bwauths make use of it.

Child Tickets

Change History (12)

comment:1 Changed 2 years ago by nickm

Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final

Should they? It makes them stand out. What harm would it do if it stopped?

(We're not actually removing it in 0.3.0.x, so calling this an 0.3.1.x bug.)

comment:2 Changed 2 years ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: unspecified

comment:3 Changed 2 years ago by teor

It was used to measure relay CPU load by ensuring that the first connection fails if the relay's CPU is heavily loaded and it can't process create cells.

I bet that probably doesn't work the same way it used to, and even if it does, the client default and consensus default are both to use create cells anyway.

So we can safely remove this option, or ignore it, and bwauth behaviour won't change, at least in 0.3.1 once #21407 is merged.

comment:4 Changed 2 years ago by nickm

Keywords: tor-dirauth try-and-find-out deprecated added
Points: 1
Summary: bwauths use FastFirstHopPKbwauths use FastFirstHopPK, which is deprecated.

comment:5 Changed 20 months ago by teor

Component: Core Tor/TorCore Tor/Torflow
Milestone: Tor: unspecified
Owner: set to tom

comment:6 Changed 20 months ago by tom

It sounds like (since bwauths aren't generally using 0.3.1) that this _could_ cause some change so we should measure, correct?

comment:7 Changed 20 months ago by tom

I've removed 'FastFirstHopPK 0' from my torrcs and HUPed, so in a week we'll have some data on this.

comment:8 in reply to:  6 Changed 20 months ago by arma

Replying to tom:

It sounds like (since bwauths aren't generally using 0.3.1) that this _could_ cause some change so we should measure, correct?

It shouldn't make any change. The bwauths were early adopters of the value 0 for this option, and in the many years since they started using 0, the rest of Tor caught up and everybody starting using 0. Then recently we took out the ability to choose anything other than 0.

(In earlier Tor versions, the networkstatus_get_param("usecreatefast") defaulted to 1, and in more recent Tor versions, it defaults to 0. But in either case, it uses the param set by the consensus, which has been 0 for years.)

tl;dr I think this is not a big deal, just delete the line and move on.

Last edited 20 months ago by arma (previous) (diff)

comment:9 Changed 20 months ago by tom

Oh okay, cool. I'll measure something else then!

comment:10 Changed 20 months ago by Sebastian

Resolution: invalid
Status: newclosed

comment:11 Changed 20 months ago by teor

Resolution: invalid
Status: closedreopened

This requires a change to the torflow repository, so we can't close it yet.

comment:12 Changed 20 months ago by tom

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.