Opened 3 years ago

Closed 2 years ago

#21403 closed enhancement (fixed)

prop224: Implement HS descriptor fetching

Reported by: haxxpop Owned by: dgoulet
Priority: Very High Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224
Cc: Actual Points:
Parent ID: #17242 Points: 7
Reviewer: Sponsor: SponsorR-must

Description

Before the client actually can connect to the service, it has to fetch the descriptor first. As already specified in prop224 section 2.1 and 2.2.6

The client needs to parse the service's master public key from the onion address, derive the blinded public key, and then use that blinded public key to fetch the descriptor from the HSDir.

(Note that, this ticket doesn't implement how to pick the HSDir)

Child Tickets

Change History (21)

comment:1 Changed 3 years ago by haxxpop

Summary: prop224: Implementation HS directory fetchingprop224: Implementation HS descriptor fetching

comment:2 Changed 3 years ago by haxxpop

Summary: prop224: Implementation HS descriptor fetchingprop224: Implement HS descriptor fetching

comment:4 Changed 3 years ago by haxxpop

Status: newneeds_review

comment:5 Changed 3 years ago by nickm

Keywords: review-group-16 added

comment:6 Changed 3 years ago by dgoulet

Owner: changed from haxxpop to dgoulet
Points: parent
Status: needs_reviewaccepted

Oh we can't merge this yet. We aren't there at all in development because this is client/control port behavior. I'll move that in Accepted state so we don't get confused for the 031 window.

It will make me the owner but it's really a good way for us to not forget it. me and asn are well aware of this ticket and code so we won't forget it :).

comment:7 Changed 3 years ago by asn

Reviewer: asn

Putting myself as the reviewer here but we are not there yet here. This ticket will be examined more deeply when we start client-side implementation.

comment:8 Changed 3 years ago by nickm

Keywords: review-group-16 removed

comment:9 Changed 3 years ago by dgoulet

Priority: MediumVery High

Prioritize prop224 tickets for 031 milestone. They are all "Enhancement".

comment:10 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.1.x-finalTor: 0.3.2.x-final

prop224 tickets going in 032 for early merge. Decided after Amsterdam meeting.

comment:11 Changed 2 years ago by asn

Status: acceptedneeds_review

I pushed an initial branch for this (and #21855) in my branch bug21403_draft.

It handles everything from the point where the user requests an onion address, to picking HSDirs, fetching descriptors, storing them in the cache, looking them up, and retrying dir requests when needed. It doesn't do any introduction-related actions.

Please check it out!

comment:12 Changed 2 years ago by asn

Points: 7

comment:13 Changed 2 years ago by asn

And here is the gitlab merge request for bug21403_draft: https://gitlab.com/asn/tor/merge_requests/16

comment:14 Changed 2 years ago by nickm

Keywords: review-group-18 added

comment:15 Changed 2 years ago by asn

Reviewer: asn

comment:16 Changed 2 years ago by nickm

Keywords: review-group-18 removed

comment:17 Changed 2 years ago by nickm

Keywords: review-group-19 added

comment:18 Changed 2 years ago by dgoulet

Keywords: review-group-19 removed

Not yet ready for upstream merge.

comment:19 Changed 2 years ago by dgoulet

Ongoing development is now in: ticket21403_032_01.

I've picked up asn's branch and addressed haxxpop review in there.

comment:20 Changed 2 years ago by dgoulet

Status: needs_reviewassigned

comment:21 Changed 2 years ago by dgoulet

Resolution: fixed
Status: assignedclosed

All done in #17242 which was just merged.

Note: See TracTickets for help on using tickets.