Opened 9 months ago

Closed 5 weeks ago

#21405 closed defect (implemented)

Clarify "address" in man page: IPv4, IPv6, hostname?

Reported by: teor Owned by: nickm
Priority: Low Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: tor-doc easy intro manpage
Cc: kleft Actual Points:
Parent ID: #18892 Points: 1
Reviewer: Sponsor:

Description

The DirAuthority line only takes an IPv4 address as an "address".
But other torrc options take IPv6 addresses or hostnames.

We should clarify what we mean when we say "address".

Reported by Andrew Smith:
https://lists.torproject.org/pipermail/tor-relays/2017-February/011876.html

Child Tickets

Change History (12)

comment:1 Changed 9 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.1.x-final

comment:2 Changed 8 months ago by nickm

Keywords: triaged-out-20170308 added
Milestone: Tor: 0.3.1.x-finalTor: unspecified

Deferring all 0.3.1 tickets with status == new, owner == nobody, sponsor == nobody, points > 0.5, and priority < high.

I'd still take patches for most of these -- there's just nobody currently lined up to work on them in this timeframe.

comment:3 Changed 6 months ago by kleft

Cc: kleft added
Parent ID: #18892

comment:4 Changed 4 months ago by nickm

Keywords: tor-doc intro manpage added; doc triaged-out-20170308 removed

comment:5 Changed 5 weeks ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.2.x-final
Owner: set to nickm
Status: newaccepted

comment:6 Changed 5 weeks ago by nickm

Status: acceptedneeds_review

my branch ticket21405 has tweaks here.

comment:7 Changed 5 weeks ago by dgoulet

Status: needs_reviewneeds_revision

In the case of __IP__, I don't see any mentions of what is the expected format? I'm asking because for v4 it is easy but seems that for v6 we do require [] from what I can see in the code in terms of parsing.

It's kind of obvious the brackets are needed for IPv6 because you can put a port with :PORT but could we make a quick note maybe at the start of the man page that every IPv6 address needs the brackets?

comment:8 Changed 5 weeks ago by nickm

I've thrown some boilerplate around whenever we say __IP__. Better now?

comment:9 Changed 5 weeks ago by dgoulet

Hmmm I don't see anything for ReachableAddresses, ReachableDirAddresses and ReachableORAddresses?

comment:10 Changed 5 weeks ago by nickm

I think they all document that they're in the same format as ExitPolicy? Also ReachableDirAddresses is deprecated.

comment:11 Changed 5 weeks ago by dgoulet

Status: needs_revisionmerge_ready

Oh yes! Good stuff.

comment:12 Changed 5 weeks ago by nickm

Resolution: implemented
Status: merge_readyclosed

ok; merged!

Note: See TracTickets for help on using tickets.