Opened 9 months ago

Closed 8 months ago

#21430 closed defect (fixed)

Graphs have empty paths when bandwidth data is unavailable

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #21274 Points:
Reviewer: Sponsor:

Description

For some relays Onionoo does not have bandwidth data for all time periods. For instance B743BE28571D87AEFF9C409756644DB5C64A7C45 is missing its 5 years data.

When data is unavailable the graphs are empty except for the legend. However the path elements are still created leading to W3C validator errors such as

Element path is missing required attribute d.

FWICT this issue was partially addressed by #19553 but was solved by removing more recent graphs instead of having Atlas detect and handle unavailable data.

Child Tickets

Change History (3)

comment:1 Changed 8 months ago by RaBe

Status: newneeds_review

Skipping graphs that have no data, so the "No Data Available" image is maintained:

https://github.com/RaphaelBergmann/atlas/commit/301a2d659722b4e69b30da9f0913b31d4d248900

comment:2 Changed 8 months ago by cypherpunks

The empty line that is introduced contains trailing spaces, other than that it LGTM.

comment:3 Changed 8 months ago by irl

Resolution: fixed
Status: needs_reviewclosed

Merged (amending the commit to remove the whitespace blank line). Thanks. (:

Note: See TracTickets for help on using tickets.