Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21434 closed defect (fixed)

Graphs overflow into their right border on smaller screens

Reported by: cypherpunks Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently the graphs use the span8 class which causes them to keep 4 columns of distance from the right (because the entire width is divided into 12 columns). On smaller screens this causes the graphs to overflow into their borders.

Using the span8 class makes it so graphs will always be underneath each other. Keeping this layout and solving the overflow issue is easy by just using the span12 class. This makes the graphs (and their borders) use the entire screen width.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by RaBe

Status: newneeds_review

I removed the span8 classes, so now the border is shown correctly based on the graphs width. Since each graph is an on-the-fly generated inline svg element with fixed pixel widths, unfortunately we can't downscale (or upscale) that to the max browser width (at least not without great effort).

https://github.com/RaphaelBergmann/atlas/commit/62703f008a04b9a8b94be1f3f381bb04f3370e20

comment:2 Changed 3 years ago by cypherpunks

Status: needs_reviewmerge_ready

OP here. Changes look good.

comment:3 Changed 3 years ago by irl

Thanks for your work on this, merged! (:

cypherpunks: Please do not set merge_ready yourself. While I'm happy for anyone and everyone to contribute patches and reviews, the merge decisions need to be taken by known trusted people.

comment:4 Changed 3 years ago by irl

Resolution: fixed
Status: merge_readyclosed

comment:5 in reply to:  3 Changed 3 years ago by cypherpunks

Replying to irl:

cypherpunks: Please do not set merge_ready yourself. While I'm happy for anyone and everyone to contribute patches and reviews, the merge decisions need to be taken by known trusted people.

Okay, I'll refrain from doing so in the future.

Note: See TracTickets for help on using tickets.