Opened 3 years ago

Closed 3 years ago

#21482 closed task (implemented)

Run clang-scan on tor master

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: technical-debt continuous-integration static-analysis
Cc: Actual Points:
Parent ID: Points: 1
Reviewer: Sponsor:


I think it might have caught #21471, maybe we should run it on 0.3.0 or 0.3.1?

But that requires someone to actually take the time to do it.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by nickm

Running scan-build now. For reference there's a script in ./scripts/test/ , but the false positive rate is pretty high.

comment:2 Changed 3 years ago by teor

How did it go?
(Can you post the log somewhere?)

Perhaps we could tune it so the scanners that yield a large number of false positives are excluded?

comment:3 Changed 3 years ago by nickm

Keywords: technical-debt continuous-integration static-analysis added
Milestone: Tor: unspecifiedTor: 0.3.2.x-final

comment:4 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:5 Changed 3 years ago by nickm

I've two bugs so far: #23488 and #23487.

comment:6 Changed 3 years ago by nickm

Status: acceptedneeds_review

Okay; I've tried to minimize false positives. scan-build-032 is ready for review.

comment:7 Changed 3 years ago by nickm

I've also created #23491 to handle "automate this."

comment:8 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged the patch here, with followups.

Note: See TracTickets for help on using tickets.