Opened 3 years ago

Closed 3 years ago

#21498 closed defect (fixed)

dir-spec says extra-info-digest has one digest but the code has two

Reported by: arma Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: spec
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

dir-spec.txt says

   "extra-info-digest" digest NL

       [At most once]

       "Digest" is a hex-encoded digest (using upper-case characters) of the
       router's extra-info document, as signed in the router's extra-info
       (that is, not including the signature).  (If this field is absent, the
       router is not uploading a corresponding extra-info document.)

But the reality is that these lines look like

extra-info-digest 9A0DC5BE9F00423F1929B10E9FEF7942481215AB HjMoC57FJUUXJ7Gwv/ouFb+otnZIfxu9cj1sh6Nd618

It looks like that second digest is a sha256, and it is related to the introduction of the extra_info_digest256 element in routerinfo_t.

I'm guessing the fix is to update the spec -- and maybe figure out what went wrong in the earlier proposal and ticket process that updating the spec got skipped. :)

Child Tickets

Change History (2)

comment:1 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.0.x-final

comment:2 Changed 3 years ago by nickm

Resolution: fixed
Status: newclosed

Fix in 0f03581e748d48.

It appears that this is waiting for me to finish actually merging proposal 220. :/

Note: See TracTickets for help on using tickets.