Opened 3 years ago

Closed 2 years ago

#21522 closed defect (implemented)

ClientDNSRejectInternalAddresses should not be deprecated in test networks.

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: review-group-23
Cc: Actual Points:
Parent ID: #21031 Points: 0.5
Reviewer: Sponsor:

Description (last modified by teor)

Warning: Testing options override the deprecated option ClientDNSRejectInternalAddresses. Is that intentional?

Yes, it's required for exits in test networks to function.
But it's only a warning, so as long as we don't remove ClientDNSRejectInternalAddresses, it's fine.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by teor

Description: modified (diff)

comment:2 Changed 3 years ago by teor

Parent ID: #21573

comment:3 Changed 2 years ago by nickm

Keywords: 031-reach added
Owner: set to nickm
Status: newaccepted

Putting these tickets in 031-reach and assigning them to me. The minimum to do is "nothing"; the maximum is "come up with a better deprecation path that doesn't break testing".

comment:4 Changed 2 years ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: 0.3.2.x-final

A better refactoring here will need to wait for 0.3.2

comment:5 Changed 2 years ago by nickm

Keywords: 031-reach removed

comment:6 Changed 2 years ago by nickm

Parent ID: #21573#21031

See ticket for review in parent.

comment:7 Changed 2 years ago by nickm

Status: acceptedneeds_review

comment:8 Changed 2 years ago by nickm

Keywords: review-group-23 added

Put 0.3.2 needs_review and merge_ready tickets into review-group-23.

comment:9 Changed 2 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

closed; see parent.

Note: See TracTickets for help on using tickets.