Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2153 closed defect (fixed)

Annotation rules not adequately enforced.

Reported by: nickm Owned by:
Priority: High Milestone: Tor: 0.2.2.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

piebeer on IRC found some potentially nasty bugs in annotation parsing.

Possible fixes in my branch "annotations_fixes". Please review.

I'm tagging this for 0.2.2.x for now, but it is a backport candidate if we're going to do another 0.2.1.x.

Child Tickets

Change History (4)

comment:1 Changed 9 years ago by nickm

Status: newneeds_review

comment:2 Changed 9 years ago by arma

8b610bf7cff9 i don't have a good handle on. i never fully grokked your router parse stuff. if you think it's more right than what you had before, that'll do for me.

4d78389720d89 looks pretty straightforwardly more correct.

comment:3 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Okay. Backported and merged back onto maint-0.2.1, maint-0.2.2, and master.

comment:4 Changed 7 years ago by nickm

Component: Tor ClientTor
Note: See TracTickets for help on using tickets.