#21535 closed enhancement (fixed)

Use Java 7's diamond operator wherever possible

Reported by: karsten Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'll shortly attach three branches that use Java 7's diamond operator wherever possible in ExoneraTor, CollecTor, and Metrics. We already did this in Onionoo and metrics-lib, so that there aren't any metrics code bases left where we'd need to do this.

Note that I didn't touch any nearby code. There's lots to be cleaned up. But let's do one thing at a time.

This was on my local TODO list for a while, and it seemed easiest to just make these changes and be able to cross out yet another item.

Child Tickets

Change History (6)

comment:2 Changed 10 months ago by iwakeh

Yes, good idea, little by little thing get done!

ExoneraTor is ready to merge.

comment:3 in reply to:  2 Changed 10 months ago by karsten

Replying to iwakeh:

Yes, good idea, little by little thing get done!

ExoneraTor is ready to merge.

Merged. Thanks for looking!

comment:4 Changed 10 months ago by iwakeh

Please find two commits on top of your metrics-web branch, which make a few steps toward the Metrics project layout standard and reduce duplication.

maxmemory is set to 2g throughout. If a run should have a different value, I can introduce another property for that.

comment:5 Changed 10 months ago by iwakeh

Status: needs_reviewmerge_ready

CollecTor looks fine, too.

Actually, also CollecTor and ExoneraTor can use descriptor-1.6.0 now.

comment:6 Changed 10 months ago by karsten

Resolution: fixed
Status: merge_readyclosed

Alright! I reviewed and merged your two commits (it's fine that maxmemory is set to 2g for all modules) and upgraded CollecTor and ExoneraTor to descriptor-1.6.0. All done here, I think. Thanks for reviewing and for writing those patches! Closing.

Note: See TracTickets for help on using tickets.