Changes between Initial Version and Version 1 of Ticket #21537, comment 14


Ignore:
Timestamp:
Apr 11, 2018, 8:31:22 PM (17 months ago)
Author:
arthuredelstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21537, comment 14

    initial v1  
    77> Thanks. I added the suggested change in `bug_21537_v3` (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_21537_v3). Let me know if that still looks good.
    88
    9 The code looks good to me, but I would suggest factoring out the repeated security checks by creating a static function like:
     9The code looks good to me, but I would suggest factoring out the security checks (which are repeated in three places) by creating a static function like:
    1010`bool IsSecureHost(nsIURI *aHostURI)`
    1111that returns true for both https and .onion URIs.