Changes between Initial Version and Version 1 of Ticket #21537, comment 17


Ignore:
Timestamp:
Apr 13, 2018, 5:11:24 PM (18 months ago)
Author:
gk
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21537, comment 17

    initial v1  
    1 Okay, how is `bug_21537_v4` (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_21537_v4)? Returning a boolean value made this slightly more complicated as we actually have more than two values to consider due to the telemtry part. But as we don't want to have the latter anyway, I just ripped it out. We can revisit that when we think we want to upstream that patch but that's a bit in the future as I am not sure whether Mozilla would take it right now anyway. There is no easy way around the HTTPS = secure equation for cookies I am afraid...
     1Okay, how is `bug_21537_v4` (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_21537_v4)? Returning a boolean value made this slightly more complicated as we actually have more than two values to consider due to the telemetry part. But as we don't want to have that anyway, I just ripped it out. We can revisit that when we think we want to upstream that patch but that's a bit in the future as I am not sure whether Mozilla would take it right now anyway. There is no easy way around the HTTPS = secure equation for cookies, I am afraid...