Opened 4 months ago

Last modified 5 weeks ago

#21540 merge_ready defect

Warning "Failure from drain_fd"

Reported by: PjotrV Owned by: nickm
Priority: Low Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.9
Severity: Minor Keywords: supressed, 029-backport, 030-backport
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: dgoulet Sponsor:

Description (last modified by dgoulet)

"Failure from drain_fd: No error [x similar messages suppressed in 72000
seconds]"

"x" stands for any number

Possible the same as #16992

Feb 18 19:41:59.564 [Warnung] Failure from drain_fd: No error [5 similar message(s) suppressed in last 7200 seconds]
Feb 18 20:04:08.501 [Hinweis] Heartbeat: Tor's uptime is 16:22 hours, with 2 circuits open. I've sent 31.55 MB and received 211.71 MB.
Feb 18 20:04:08.501 [Hinweis] Average packaged cell fullness: 73.875%. TLS write overhead: 5%
Feb 18 20:04:08.501 [Hinweis] Circuit handshake stats since last time: 1/1 TAP, 0/0 NTor.
Feb 18 20:04:08.501 [Hinweis] Since startup, we have initiated 0 v1 connections, 0 v2 connections, 0 v3 connections, and 43 v4 connections; and received 3 v1 connections, 12 v2 connections, 17 v3 connections, and 701 v4 connections.
Feb 18 21:54:40.556 [Warnung] Failure from drain_fd: No error [1 similar message(s) suppressed in last 7200 seconds]
Feb 19 00:00:07.179 [Warnung] Failure from drain_fd: No error [9 similar message(s) suppressed in last 7200 seconds]
Feb 19 01:15:16.376 [Hinweis] Interrupt: we have stopped accepting new connections, and will shut down in 30 seconds. Interrupt again to exit now.
Feb 19 15:14:06.133 [Hinweis] Tor 0.2.9.9 (git-56788a2489127072) running on Windows 7 with Libevent 2.0.22-stable, OpenSSL 1.0.2j and Zlib 1.2.8.
Feb 19 15:14:06.134 [Hinweis] Tor can't help you if you use it wrong! Learn how to be safe at https://www.torproject.org/download/download#warning
Feb 19 15:14:06.134 [Hinweis] Read configuration file "C:\Program Files (x86)\Vidalia Relay Bundle\Data\Tor\torrc".
Feb 19 15:14:06.134 [Warnung] Path for DataDirectory (C:/Program Files (x86)/Vidalia Relay Bundle/Data/Tor) is relative and will resolve to C:\Program Files (x86)\Vidalia Relay Bundle\Data\Tor. Is this what you wanted?
Feb 19 15:14:06.134 [Hinweis] Based on detected system memory, MaxMemInQueues is set to 2048 MB. You can override this by setting MaxMemInQueues by hand.
Feb 19 15:14:06.134 [Hinweis] Opening Socks listener on 127.0.0.1:9050
Feb 19 15:14:06.134 [Hinweis] Opening Control listener on 127.0.0.1:9051
Feb 19 15:14:06.134 [Hinweis] Opening OR listener on 0.0.0.0:443
Feb 19 15:14:06.135 [Hinweis] Opening Directory listener on 0.0.0.0:9030
Feb 19 17:28:38.911 [Warnung] Failure from drain_fd: No error [74 similar message(s) suppressed in last 7200 seconds]
Feb 19 20:48:42.369 [Warnung] Failure from drain_fd: No error [2 similar message(s) suppressed in last 7200 seconds]
Feb 19 21:15:07.100 [Hinweis] Heartbeat: Tor's uptime is 5:59 hours, with 3 circuits open. I've sent 55.97 MB and received 935.17 MB.
Feb 19 21:15:07.101 [Hinweis] Average packaged cell fullness: 57.651%. TLS write overhead: 5%
Feb 19 21:15:07.101 [Hinweis] Circuit handshake stats since last time: 1/1 TAP, 115/115 NTor.
Feb 19 21:15:07.101 [Hinweis] Since startup, we have initiated 0 v1 connections, 0 v2 connections, 0 v3 connections, and 148 v4 connections; and received 0 v1 connections, 10 v2 connections, 11 v3 connections, and 377 v4 connections.

Child Tickets

Change History (13)

comment:1 Changed 4 months ago by PjotrV

I've added the most important block of the log file directly, because I've got an error at creation of this ticket - like ".. empty list .." - may be regarding to the add files option in the form.

comment:2 Changed 4 months ago by dgoulet

  • Component changed from - Select a component to Core Tor/Tor
  • Description modified (diff)
  • Milestone set to Tor: 0.3.1.x-final

comment:3 Changed 4 months ago by nickm

Is this windows too? If so probably a duplicate of #16992

comment:4 Changed 4 months ago by nickm

  • Points set to 2

comment:5 Changed 4 months ago by nickm

  • Owner set to nickm
  • Status changed from new to accepted

comment:6 Changed 4 months ago by nickm

  • Priority changed from Medium to Low

comment:7 Changed 3 months ago by nickm

  • Keywords 029-backport 030-backport added
  • Status changed from accepted to needs_review

Fix in branch "bug21540_029". Possible backport.

comment:8 Changed 3 months ago by dgoulet

  • Status changed from needs_review to needs_revision

This pattern is used except in recv_ni() which removes the unneeded else:

+    if (errno == EINTR)
+      goto again;
+    else
+      return -errno;
+  }

I would suggest going for the same pattern, one or the other.

The rest lgtm.

comment:9 Changed 3 months ago by dgoulet

  • Reviewer set to dgoulet

comment:10 Changed 3 months ago by nickm

  • Milestone changed from Tor: 0.3.1.x-final to Tor: 0.3.0.x-final
  • Status changed from needs_revision to needs_review

fixup added, squashed as bug21540_029_v2. Merged to master; marking for possible backport to 0.3.0 and then maybe to 0.2.9

comment:11 Changed 6 weeks ago by arma

  • Status changed from needs_review to merge_ready

moving to state merge-ready, not because I think it should be merged into 0.3.0, but because needs-review is not the right state for it.

comment:12 Changed 6 weeks ago by arma

(maybe 'new' is better than 'merge ready'? i'm not sure of our policies around those these days.)

comment:13 Changed 5 weeks ago by nickm

  • Keywords changed from supressed 029-backport 030-backport to supressed, 029-backport, 030-backport
Note: See TracTickets for help on using tickets.