Opened 3 years ago

Closed 3 years ago

#21546 closed defect (fixed)

Adapt Tor Launcher to TBB/FF52ESR

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, tbb-7.0-must, TorBrowserTeam201703R, tbb-7.0-must-nightly
Cc: brade, mcs Actual Points:
Parent ID: #20680 Points:
Reviewer: Sponsor:

Description

Tor Launcher probably needs some tweaks for ESR52, especially with e10s enabled.

Child Tickets

Change History (10)

comment:1 Changed 3 years ago by mcs

Cc: brade mcs added

If you know of specific things that need to be fixed in Tor Launcher, please let Kathy and I know. Since Tor Launcher does not interact with browser content, it may not need any changes for e10s. In any case, Kathy and I have not found anything so far that needs to be fixed for ESR52 or e10s beyond adding <em:multiprocessCompatible>true</em:multiprocessCompatible> to install.rdf. But we have not done a lot of testing yet either.

comment:2 Changed 3 years ago by gk

Keywords: tbb-7.0-must added

comment:3 Changed 3 years ago by gk

Keywords: TorBrowserTeam201703 added

Getting those tickets on our March radar as well.

comment:4 in reply to:  1 ; Changed 3 years ago by arthuredelstein

Replying to mcs:

If you know of specific things that need to be fixed in Tor Launcher, please let Kathy and I know. Since Tor Launcher does not interact with browser content, it may not need any changes for e10s. In any case, Kathy and I have not found anything so far that needs to be fixed for ESR52 or e10s beyond adding <em:multiprocessCompatible>true</em:multiprocessCompatible> to install.rdf. But we have not done a lot of testing yet either.

I did some testing and it all seems to be working. I'll close this ticket for now and we can open individual tickets if specific ESR52 or e10s issues pop up. Sorry for the false alarm! :)

comment:5 Changed 3 years ago by arthuredelstein

Resolution: worksforme
Status: newclosed

comment:6 in reply to:  4 Changed 3 years ago by gk

Resolution: worksforme
Status: closedreopened

Replying to arthuredelstein:

Replying to mcs:

If you know of specific things that need to be fixed in Tor Launcher, please let Kathy and I know. Since Tor Launcher does not interact with browser content, it may not need any changes for e10s. In any case, Kathy and I have not found anything so far that needs to be fixed for ESR52 or e10s beyond adding <em:multiprocessCompatible>true</em:multiprocessCompatible> to install.rdf. But we have not done a lot of testing yet either.

I did some testing and it all seems to be working. I'll close this ticket for now and we can open individual tickets if specific ESR52 or e10s issues pop up. Sorry for the false alarm! :)

But we should patch the install.rdf and add the e10s compat item. Seems fine to me doing that in this ticket pointing to a patch.

comment:7 Changed 3 years ago by gk

Keywords: TorBrowserTeam201703R added; TorBrowserTeam201703 removed
Status: reopenedneeds_review

comment:8 Changed 3 years ago by brade

r=brade, r=mcs

comment:9 Changed 3 years ago by gk

Keywords: tbb-7.0-must-nightly added

We want those tickets for our first ESR52 nightlies.

comment:10 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

That's commit 336e7c8731296866dd67a090c010e41fcc26ef69 on master now.

Note: See TracTickets for help on using tickets.