Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#21562 closed defect (fixed)

Fix shell script errors in src/test/test-network.sh

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.1-alpha
Severity: Normal Keywords: 030-backport
Cc: Actual Points:
Parent ID: #21570 Points: 0.2
Reviewer: Sponsor:

Description

src/test/test-network.sh performs some trickery to locate the updated chutney version of the script, and then call it.

But this only works in bash.
So we should make it use bash, rather than gambling on the default shell (on ubuntu, this is dash).

Child Tickets

Change History (6)

comment:1 Changed 6 months ago by teor

See my branch bug21562-030: because it has to do with testing, we should put it in 0.3.0.

(And it's 3 lines, one of which is a comment.)

comment:2 Changed 6 months ago by teor

Status: newneeds_review

comment:3 Changed 6 months ago by nickm

looks okay to me but I'll wait a little, in case somebody who actually knows bash wants to review it too.

comment:4 Changed 6 months ago by teor

Parent ID: #21570

This is needed for #21570 to work.

comment:5 Changed 6 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

comment:6 Changed 6 months ago by nickm

merged as part of #21570

Note: See TracTickets for help on using tickets.