Opened 3 years ago

Closed 3 years ago

#21596 closed defect (fixed)

When hidden services stop creating new intro points, they also stop checking existing ones

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: tor-hs, 030-backport
Cc: Actual Points: 0.2
Parent ID: Points: 0.2
Reviewer: Sponsor:


This means that stale intro points can be placed in the descriptor.

Fixes issue 2 in #21446.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by teor

Milestone: Tor: 0.3.1.x-finalTor: 0.3.0.x-final
Status: newneeds_review

Please see my branch bug21596_030, which moves the failed intro circuit check so that it always occurs, even when the creation limit is exceeded.

Given how simple this change is, we might also want to put it in 0.3.0.
But again, that's up to nickm.

comment:2 Changed 3 years ago by dgoulet

Keywords: 030-backport added
Milestone: Tor: 0.3.0.x-finalTor: 0.3.1.x-final
Status: needs_reviewmerge_ready

Oh this is also a good fix! lgtm;

And yes, I believe moving that to 030 would be a good idea. I'm confident that it won't introduce instability. Flagging this for 030-backport consideration.

comment:3 Changed 3 years ago by nickm

Milestone: Tor: 0.3.1.x-finalTor: 0.3.0.x-final
Status: merge_readyneeds_review

Let's try it in 0.3.1 and see if anything explodes. :) Merging and marking for backport

comment:4 Changed 3 years ago by dgoulet

Parent ID: #21446

This is merged upstream so removing parent so we can close it at some point.

comment:5 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

No apparent explosions. Backporting to 0.3.0. Thanks everybody!

Note: See TracTickets for help on using tickets.