Opened 2 years ago

Closed 2 years ago

#21629 closed defect (fixed)

Fix broken ASan builds when switching to ESR 52

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201704R, ff52-esr, tbb-7.0-must, GeorgKoppen201703, tbb-7.0-must-nightly
Cc: mcs, brade Actual Points:
Parent ID: #21147 Points:
Reviewer: Sponsor:

Description

Compiling Firefox 52 ESR with GCC and ASan breaks (see https://bugzilla.mozilla.org/show_bug.cgi?id=1272498). Unfortunately the complex fix landed merely days after the code moved to aurora and Mozilla folks were unwilling to uplift it. We need to ship an own patch. Fortunately, a much simpler one is available: https://bug1272498.bmoattachments.org/attachment.cgi?id=8764936.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by gk

Keywords: GeorgKoppen201703 added

Adding to my plate.

comment:2 Changed 2 years ago by gk

Keywords: tbb-7.0-must-nightly added

We want those tickets for our first ESR52 nightlies.

comment:3 Changed 2 years ago by gk

Cc: mcs brade added
Keywords: TorBrowserTeam201704R added; TorBrowserTeam201703 removed
Status: newneeds_review

comment:4 Changed 2 years ago by mcs

r=brade, r=mcs
This looks fine to us.

comment:5 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. This is commit 4e4ad8c85da26f6b53d0c88a7e3f733961fae73e on tor-browser-52.0.2esr-7.0-1.

Note: See TracTickets for help on using tickets.