add new column for icons that do not represent tor spec flags

added component::metrics/relay search owner::RaBe priority::medium resolution::fixed severity::normal status::closed type::enhancement labels

We could also add "Currently Running" from #6355 (moved) (Running is a flag, but "Currently Running" is not).

Also, we could add the NoEdConsensus flag (#21636 (moved)), which is a flag, but it's synthesised by the authorities based on key pinning status and consensus method.

Are we talking about a column on the details page or on the search page?

cypherpunks: This should be another column on the search page, and a separate block of icons in the details page to distinguish these synthetic flags from actual tor spec flags.

Replying to irl:

cypherpunks: This should be another column on the search page, and a separate block of icons in the details page to distinguish these synthetic flags from actual tor spec flags.

Sign me up for wanting the "has this relay earned a tshirt yet" flag in this category then. :)

So, here's something to start with (for now, just the search page):

I added an on-/offline indicator at the left, I added a properties column, I moved the not recommended ~~flag~~ property there, I added an IPv6 icon based on or_addresses and I prepared a T-Shirt icon (but I think I don't get that information yet from Onionoo) :) I also added the NoEdConsensus flag, however I did not find any relay with this set. Thoughts?

https://github.com/RaphaelBergmann/atlas/compare/task-21635

Trac:
Username: RaBe

I like the first column.

Can you make the 'Not recommended' red again? v6 should be green I think. I guess we will have some more discussions about the 'v6' icon (since there are multiple IPv6 related properties), but this ticket is just about the column itself - which is fine.

Minor: I'd prefer to have the properties column before the flags column. The properties column might become more relevant than the flags column.

Trac:
Username: tyseom

I initially made the NoRecVer icon red to distinguish it from the other flags. Now that it has an own column where it clearly stands out, I feel like we would become too colorful if we'd give every property icon an own color... Or is it just me? :)

Can you tell me what IPv6 icons / properties we'll need? So I can prepare some that we then can discuss.

For now, the properties column is mostly empty, so I don't (yet) feel like moving it before the flags column. But if we add more properties/icons and it becomes more important, why not :)

Trac:
Username: RaBe

Replying to RaBe:

I initially made the NoRecVer icon red to distinguish it from the other flags. Now that it has an own column where it clearly stands out, I feel like we would become too colorful if we'd give every property icon an own color... Or is it just me? :) That's not just you. I also agree we don't add colored icons. Their shapes are distinct enough.

Can you tell me what IPv6 icons / properties we'll need? So I can prepare some that we then can discuss. I propose creating new tickets for these discussions. Likewise, your changes already group too many tickets in one. The online/offline column should be split off and be discussed in #6355 (moved). The addition of the properties column should be separated from adding each icon so each commit can be linked to the appropriate ticket.

Replying to cypherpunks:

The addition of the properties column should be separated from adding each icon so each commit can be linked to the appropriate ticket. You're right, I wanted too much at once :) I added the on-/offline indicator in #6355 (moved). Here's just the patch to move NoRecVer to the new properties column (even in detail view):

https://github.com/RaphaelBergmann/atlas/commit/3c5e4bfdf4af83f43c9071eec707699f62a0e646

Trac:
Username: RaBe
Status: new to needs_review

Trac:
Username: RaBe
Owner: irl to RaBe
Status: needs_review to assigned

Trac:
Username: RaBe
Status: assigned to needs_review

Merged. Thanks.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #22037 (moved)

add new column for icons that do not represent tor spec flags

Child items ...

Activity