Opened 10 months ago

Closed 8 months ago

#21635 closed enhancement (fixed)

add new column for icons that do not represent tor spec flags

Reported by: cypherpunks Owned by: RaBe
Priority: Medium Milestone:
Component: Metrics/Atlas Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

(opened because of https://trac.torproject.org/projects/tor/ticket/10401#comment:2)

Tickets

#10401
#6355
#21367

are about new icons about relay properties that do not represent a tor flag (as defined in the spec).

To make people happy that dislike icons in the flags column that are not actually flags add an additional column "properties" or similar.

in that column we could add:

Child Tickets

Change History (12)

comment:1 Changed 10 months ago by teor

We could also add "Currently Running" from #6355 (Running is a flag, but "Currently Running" is not).

Also, we could add the NoEdConsensus flag (#21636), which *is* a flag, but it's synthesised by the authorities based on key pinning status and consensus method.

comment:2 Changed 10 months ago by cypherpunks

Are we talking about a column on the details page or on the search page?

comment:3 Changed 10 months ago by irl

cypherpunks: This should be another column on the search page, and a separate block of icons in the details page to distinguish these synthetic flags from actual tor spec flags.

comment:4 in reply to:  3 Changed 10 months ago by arma

Replying to irl:

cypherpunks: This should be another column on the search page, and a separate block of icons in the details page to distinguish these synthetic flags from actual tor spec flags.

Sign me up for wanting the "has this relay earned a tshirt yet" flag in this category then. :)

comment:5 Changed 9 months ago by RaBe

So, here's something to start with (for now, just the search page):

I added an on-/offline indicator at the left, I added a properties column, I moved the not recommended flag property there, I added an IPv6 icon based on or_addresses and I prepared a T-Shirt icon (but I think I don't get that information yet from Onionoo) :) I also added the NoEdConsensus flag, however I did not find any relay with this set. Thoughts?

https://github.com/RaphaelBergmann/atlas/compare/task-21635

http://cc-ltd.net/trac/properties.png

comment:6 Changed 9 months ago by tyseom

I like the first column.

Can you make the 'Not recommended' red again?
v6 should be green I think.
I guess we will have some more discussions about the 'v6' icon (since there are multiple IPv6 related properties), but this ticket is just about the column itself - which is fine.

Minor:
I'd prefer to have the properties column before the flags column. The properties column might become more relevant than the flags column.

Last edited 9 months ago by tyseom (previous) (diff)

comment:7 Changed 9 months ago by RaBe

I initially made the NoRecVer icon red to distinguish it from the other flags. Now that it has an own column where it clearly stands out, I feel like we would become too colorful if we'd give every property icon an own color... Or is it just me? :)

Can you tell me what IPv6 icons / properties we'll need? So I can prepare some that we then can discuss.

For now, the properties column is mostly empty, so I don't (yet) feel like moving it before the flags column. But if we add more properties/icons and it becomes more important, why not :)

comment:8 in reply to:  7 ; Changed 9 months ago by cypherpunks

Replying to RaBe:

I initially made the NoRecVer icon red to distinguish it from the other flags. Now that it has an own column where it clearly stands out, I feel like we would become too colorful if we'd give every property icon an own color... Or is it just me? :)

That's not just you. I also agree we don't add colored icons. Their shapes are distinct enough.

Can you tell me what IPv6 icons / properties we'll need? So I can prepare some that we then can discuss.

I propose creating new tickets for these discussions. Likewise, your changes already group too many tickets in one. The online/offline column should be split off and be discussed in #6355. The addition of the properties column should be separated from adding each icon so each commit can be linked to the appropriate ticket.

comment:9 in reply to:  8 Changed 9 months ago by RaBe

Status: newneeds_review

Replying to cypherpunks:

The addition of the properties column should be separated from adding each icon so each commit can be linked to the appropriate ticket.

You're right, I wanted too much at once :) I added the on-/offline indicator in #6355. Here's just the patch to move NoRecVer to the new properties column (even in detail view):

https://github.com/RaphaelBergmann/atlas/commit/3c5e4bfdf4af83f43c9071eec707699f62a0e646

comment:10 Changed 9 months ago by RaBe

Owner: changed from irl to RaBe
Status: needs_reviewassigned

comment:11 Changed 9 months ago by RaBe

Status: assignedneeds_review

comment:12 Changed 8 months ago by irl

Resolution: fixed
Status: needs_reviewclosed

Merged. Thanks.

Note: See TracTickets for help on using tickets.