Prop274: Rotate onion keys less frequently

Let's implement proposal 274: This proposal will save a fair amount of bandwidth now, and even more once we have consensus diffs.

changed milestone to %Tor: 0.3.1.x-final

added TorCoreTeam201703 actualpoints::2.1 component::core tor/tor milestone::Tor: 0.3.1.x-final owner::ahf points::2 priority::medium resolution::implemented reviewer::nickm severity::normal sponsor::4 status::closed type::defect labels

Trac:
Owner: N/A to ahf
Status: new to assigned

Trac:
Keywords: N/A deleted, TorCoreTeam201703 added

Trac:
Status: assigned to accepted

I've added a patch set that is ready for review in my Gitlab branch 'bugs/21641': https://gitlab.com/ahf/tor/commits/bugs/21641

Trac:
Actualpoints: N/A to 2.1
Status: accepted to needs_review

Looks good!

Suggestions:

• When a time interval (like MIN/MAX/DEFAULT_ONION_KEY_LIFETIME) has a unit other than seconds, put the unit in the name. (eg, "MIN_ONION_KEY_LIFETIME_DAYS"). Otherwise people tend to assume seconds. Same for DEFAULT/MIN onion_key_grace_period.
• Maybe we should check whether the onion key is expired more frequently than the get_onion_key_lifetime() interval? -- otherwise, if the interval changes in the consensus, we won't reach the interior of rotate_onion_key_callback(). Same for the other callback.
• The documentation for expire_old_onion_keys should make it clear that the function doesn't perform a grace period check.
• This branch needs a changes file.

(Also please remember when you make these changes, fixup commits are easier to review than a completely new or rebased branch.)

Trac:
Reviewer: N/A to nickm
Status: needs_review to needs_revision

I've updated my branch with a set of fixup commits and one additional "real" commit.

Trac:
Status: needs_revision to needs_review

LGTM; Squashed and merged. This should begin having a modest effect on directory bandwidth immediately, which will grow as more relays upgrade. We should keep an eye on upgraded relays, of course, to make sure that they don't have any weird side effects from the increased interval.

Trac:
Resolution: N/A to implemented
Status: needs_review to closed

closed

changed time estimate to 16h

added 16h 48m of time spent

moved to tpo/core/tor#21641 (closed)