#21665 closed task (fixed)

Prop278: Establish an upper-bound for LZMA2 memory usage

Reported by: ahf Owned by: ahf
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201703, prop278
Cc: Actual Points: 0.2
Parent ID: Points: 3
Reviewer: Sponsor: Sponsor4

Description

Our initial analysis shows that LZMA2 can be quite a memory hog, which means we should establish some sort of upper-bound for its memory usage and how we can actually enforce it.

Child Tickets

Change History (10)

comment:1 Changed 12 months ago by ahf

Owner: set to ahf
Status: newaccepted

comment:2 Changed 12 months ago by ahf

Keywords: TorCoreTeam201703 added

comment:3 Changed 11 months ago by ahf

Keywords: prop278 added

Add prop278 keyword.

comment:4 Changed 10 months ago by nickm

Parent ID: #21663

(unparenting this ticket)

comment:5 Changed 10 months ago by ahf

Actual Points: 0.2
Status: acceptedneeds_review

Patch for adding an upper bound for LZMA decoding can be found at https://gitlab.com/ahf/tor/merge_requests/7/

comment:6 Changed 10 months ago by nickm

Status: needs_reviewmerge_ready

Looks good. I had a couple of questions on the ticket.

comment:7 Changed 10 months ago by ahf

Answered one question, asked another on the merge request.

comment:8 Changed 10 months ago by ahf

Want a follow-up commit on this branch where we rename our LZMA option to x-tor-lzma before we merge?

comment:9 Changed 10 months ago by nickm

sure!

comment:10 Changed 10 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged and renamed it to x-tor-lzma.

Note: See TracTickets for help on using tickets.