Opened 3 years ago

Closed 3 years ago

#21666 closed task (fixed)

Prop278: Code to decide whether we want to request and/or provide CPU-intensive compression methods

Reported by: ahf Owned by:
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201703, prop278
Cc: ahf Actual Points:
Parent ID: Points: 4
Reviewer: Sponsor: Sponsor4

Description (last modified by arma)

We need some code in Tor to decide if or when we want to use and provide CPU-intensive compression operations. The biggest concern in Prop278 is LZMA2.

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by ahf

Keywords: TorCoreTeam201703 added

comment:2 Changed 3 years ago by teor

Is the compression happening on the main thread?
Because many tor relays are main-thread CPU bound, but have extra cores.

comment:3 Changed 3 years ago by nickm

Right now all the compression's in the main thread.

comment:4 Changed 3 years ago by ahf

Keywords: prop278 added

Add prop278 keyword.

comment:5 Changed 3 years ago by nickm

Cc: ahf added

Can we close this? We've moved all precomputed compression out of the main thread, and we've decided that expensive compression should _never_ be done while streaming. Is that enough?

comment:6 Changed 3 years ago by arma

Description: modified (diff)

comment:7 Changed 3 years ago by ahf

Resolution: fixed
Status: newclosed

Yes, this can be closed. The solutions are in #21668 (background compression of consensus) and #21667 (will ensure LZMA isn't used for any non-precompressed data) respectively.

Note: See TracTickets for help on using tickets.