Opened 3 years ago

Closed 3 years ago

#21668 closed task (implemented)

Prop278: Update cached_dir_t and related types to no longer assume single compresison method

Reported by: ahf Owned by: ahf
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201703, prop278
Cc: neel@… Actual Points:
Parent ID: #21667 Points: 2
Reviewer: Sponsor: Sponsor4

Description

Update the data-types for cached_dir_t to handle multiple available compression schemes.

See also: #21651

Child Tickets

Attachments (1)

tor-multcomp-p1.patch (1.4 KB) - added by neel 3 years ago.
Patch to add multiple compression types to cached_dir_t

Download all attachments as: .zip

Change History (11)

comment:1 Changed 3 years ago by ahf

Keywords: TorCoreTeam201703 added

comment:2 Changed 3 years ago by ahf

Keywords: prop278 added

Add prop278 keyword.

Changed 3 years ago by neel

Attachment: tor-multcomp-p1.patch added

Patch to add multiple compression types to cached_dir_t

comment:3 Changed 3 years ago by neel

I did submit a patch, but I am unsure on what I am missing. I don't believe this patch is complete.

Also, if this patch isn't complete, could you please tell me some of the data types which are related?

comment:4 Changed 3 years ago by neel

Cc: neel@… added

comment:5 Changed 3 years ago by nickm

Owner: set to nickm
Status: newaccepted

comment:6 Changed 3 years ago by ahf

Owner: changed from nickm to ahf
Status: acceptedassigned

comment:7 Changed 3 years ago by nickm

ahf, have a look at compress_consensus_more_ways. It needs tests, and it doesn't do all of this ticket, but it seems to work for me and at least it doesn't keep the old tests from passing. :)

comment:8 Changed 3 years ago by nickm

actual_points += .2

comment:9 Changed 3 years ago by nickm

Parent ID: #21667
Status: assignedneeds_review

Included in #21667

comment:10 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Merged as part of #21667

Note: See TracTickets for help on using tickets.