Opened 3 years ago

Closed 6 months ago

#21678 closed enhancement (implemented)

Unify Windows and Unix API for tor_read_all_handle() in util.c

Reported by: ahf Owned by: ahf
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 034-triage-20180328, 034-removed-20180328
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While working on #21654 I noticed that we have some different code paths that depends upon whether we're running on Windows or not where it would be trivial to turn them into a single code path.

I do not have access to a Windows machine right now, so it would be useful if someone could help test the patch(es).

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by ahf

Owner: set to ahf
Status: newaccepted

comment:2 Changed 3 years ago by ahf

I've added an untested patch to https://gitlab.com/ahf/tor/commits/bugs/21678 - it would be useful to get someone with a Windows machine to try it out. Otherwise, I'll try to get a Windows environment up and running and try it out there.

I'm not marking this issue as needs_review since the code is still untested.

comment:3 Changed 3 years ago by nickm

See also #11660

comment:4 Changed 3 years ago by nickm

Parent ID: #21654

comment:5 Changed 2 years ago by ahf

Milestone: Tor: 0.3.1.x-finalTor: 0.3.2.x-final

Postponing this to 0.3.2.

comment:6 Changed 2 years ago by nickm

See #22380 if we do this.

comment:7 Changed 2 years ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

comment:8 Changed 20 months ago by dgoulet

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

comment:9 Changed 18 months ago by nickm

Keywords: 034-triage-20180328 added

comment:10 Changed 18 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:11 Changed 18 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

comment:12 Changed 6 months ago by ahf

Resolution: implemented
Status: acceptedclosed

These functions was removed as part of the new process subsystem in 0.4.0.

Note: See TracTickets for help on using tickets.