Opened 3 years ago

Closed 3 years ago

#21699 closed enhancement (fixed)

Remove HTML5 shim from index.html

Reported by: Christian Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Minor Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

PrivacyBadger noted that we're loading some elements from Google into the
atlas.torproject.org website - and it turns out that index.html tries to load
some HTML5 shim for IE. As the URL produces a 404 anyway, remove it. If IE
really needs these bits, we should deliver it on our own, the license should
allow this:

https://cdnjs.cloudflare.com/ajax/libs/html5shiv/3.7.3/html5shiv.js
@preserve HTML5 Shiv 3.7.3 | @afarkas @jdalton @jon_neal @rem | MIT/GPL2 Licensed

Child Tickets

Attachments (1)

atlas_index.diff.txt.gz (761 bytes) - added by Christian 3 years ago.
Remove HTML5 shim from index.html

Download all attachments as: .zip

Change History (4)

Changed 3 years ago by Christian

Attachment: atlas_index.diff.txt.gz added

Remove HTML5 shim from index.html

comment:1 Changed 3 years ago by teor

This resource loads fine for me in Tor Browser and in a regular browser.

But loading this shim via cloudflare will likely lead to poor and variable user experience:

  • cloudflare blocks some tor exits,
  • cloudflare has a bug where it delivers HTML CAPTCHAs instead of JS resources (which effectively blocks JS resources)

But I could not find an exit which cdnjs.cloudflare.com blocks (even after trying >10), so perhaps they have whitelisted tor for this service.

comment:2 Changed 3 years ago by cypherpunks

Status: newneeds_revision

I agree with removing the shim on the grounds of nobody complaining about Atlas being broken in IE while the shim was unavailable. However, the attachment isn't a git patch generated by git format-patch and cannot be applied with git am. Also could you format the git message to something like http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html (maybe this link is useful for the Atlas wiki?).

comment:3 Changed 3 years ago by irl

Resolution: fixed
Status: needs_revisionclosed

As I don't want privacy leaks hanging around, the patch is now merged.

@Christian, please follow the guidelines that cypherpunks has pointed out if you contribute in the future, it makes my life easier.

@cypherpunks, I'll add that link to the wiki, it's a handy resource. (:

Note: See TracTickets for help on using tickets.