Upgrade Go to 1.8.1
Note:
Go 1.8 now only supports OS X 10.8 or later. This is likely the last Go release to support 10.8. Compiling Go or running binaries on older OS X versions is untested.
See also #21709 (moved) for Go 1.7.5. I'm going to test a 1.7.5 patch before working on 1.8.
Activity
Go 1.8 fixes GH#15457, which means we can remove the [[comment:5:ticket:18333|workaround introduced for 1.6.2]].
Replying to dcf:
Note:
Go 1.8 now only supports OS X 10.8 or later. This is likely the last Go release to support 10.8. Compiling Go or running binaries on older OS X versions is untested.
Ticket about dropping support for OS X 10.6, 10.7, 10.8 in Tor Browser: #18530 (moved).
Trac:
Description: * blog postNote:
Go 1.8 now only supports OS X 10.8 or later. This is likely the last Go release to support 10.8. Compiling Go or running binaries on older OS X versions is untested.
See also #21709 (moved) for Go 1.7.5. I'm going to test a 1.7.5 patch before working on 1.8.
to
Note:
Go 1.8 now only supports OS X 10.8 or later. This is likely the last Go release to support 10.8. Compiling Go or running binaries on older OS X versions is untested.
See also #21709 (moved) for Go 1.7.5. I'm going to test a 1.7.5 patch before working on 1.8.
Summary: Upgrade Go to 1.8 to Upgrade Go to 1.8.1Hi, two patches for review:
- 0001-Bump-SANDBOX_TAG-to-35fb3e0cebd73c9a93bee68e1a12a596.patch: "Fix compilation with Go 1.8."
- 0002-Bug-21710-Upgrade-Go-to-1.8.1.patch: Upgrades GO_VER and GO_HASH and removes a workaround.
There's no tag of sandboxed-tor-browser that has the Go 1.8 fix yet (the first patch). I don't know if you want to wait for a new tag before merging this.
I tested this with
make alphaon top of bug_21753_v3 from #21753 (moved). I only tested running it on linux-amd64 (bootstrapping with obfs4).Trac:
Status: new to needs_review
Keywords: tbb-gitian deleted, tbb-gitian TorBrowserTeam201704R added
Yes, I think we wait for a new tag. I am a bit confused about your commit message (just nits):
- "Remove workarounds for fixed upstream bug" <- it seems you are removing just one and not several in your patch?
- "I wasn't able to remove the cc-for-target workaround for GitHub been fixed" <- I have a hard time understanding that one.
Replying to gk:
Yes, I think we wait for a new tag. I am a bit confused about your commit message (just nits):
- "Remove workarounds for fixed upstream bug" <- it seems you are removing just one and not several in your patch?
- "I wasn't able to remove the cc-for-target workaround for GitHub been fixed" <- I have a hard time understanding that one.
Sorry, there were some errors in the commit message. I'll paste the long error output here and shorten the log message.
Despite https://github.com/golang/go/issues/15457 supposedly being fixed,
make.bashsays:echo '##### Building packages and commands for darwin/amd64.' CC='/home/debian/build/clang/bin/clang -target x86_64-apple-darwin10 -mlinker-version=136 -B /home/debian/build/cctools/bin -isysroot /home/debian/build/MacOSX10.7.sdk -std=gnu99' /home/debian/build/go/pkg/tool/linux_amd64/go_bootstrap install -gcflags _ -ldflags _ -v std cmdit ends up running something that discards all the options:
cd /home/debian/build/go/src/plugin CGO_LDFLAGS="-g" "-O2" /home/debian/build/go/pkg/tool/linux_amd64/cgo -objdir $WORK/plugin/_obj/ -importpath plugin -- -I $WORK/plugin/_obj/ -g -O2 plugin_dlopen.go /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches -fno-common -I $WORK/plugin/_obj/ -g -O2 -o $WORK/plugin/_obj/_cgo_export.o -c $WORK/plugin/_obj/_cgo_export.c /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches -fno-common -I $WORK/plugin/_obj/ -g -O2 -o $WORK/plugin/_obj/plugin_dlopen.cgo2.o -c $WORK/plugin/_obj/plugin_dlopen.cgo2.c /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches -fno-common -I $WORK/plugin/_obj/ -g -O2 -o $WORK/plugin/_obj/_cgo_main.o -c $WORK/plugin/_obj/_cgo_main.c /home/debian/build/clang/bin/clang -I . -fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches -fno-common -o $WORK/plugin/_obj/_cgo_.o $WORK/plugin/_obj/_cgo_main.o $WORK/plugin/_obj/_cgo_export.o $WORK/plugin/_obj/plugin_dlopen.cgo2.o -g -O2and fails with these errors:
/tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.o: In function `_cgo_e64586f1776f_Cfunc_pluginLookup': /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x2f): undefined reference to `dlsym' /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x3c): undefined reference to `dlerror' /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.o: In function `_cgo_e64586f1776f_Cfunc_pluginOpen': /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x80): undefined reference to `dlopen' /tmp/go-build417206360/plugin/_obj/plugin_dlopen.cgo2.c:(.text+0x8d): undefined reference to `dlerror' clang: error: linker command failed with exit code 1 (use -v to see invocation)sandboxed-tor-browser has a 0.0.5 patch now, and I was able to do a complete build for all platforms and test obfs4 bootstrap on linux-amd64. I applied these patches on top of 1942f7b2f6. I additionally applied 0001-Ignore-dump_syms_regtest.o.patch:ticket:21954 (which has already been merged to master) to fix the webrtc error of #21954 (moved).
-
Thanks. FWIW: I picked patch.2 as I had trouble to get patch.3 to apply. While reviewing the differences it seemed to me they were Go unrelated and thus picking patch.2 should be fine. This is commit 9d546f20ae711e7df9c574d9bdfccf34ddf1b650 on
master.Trac:
Status: needs_review to closed
Resolution: N/A to fixed mentioned in issue #21913 (moved)
mentioned in issue #21954 (moved)
mentioned in issue #21954 (moved)
mentioned in issue tpo/applications/tor-browser#21913 (closed)