Is our patch for #19212 still necessary in ESR52?

I reverted the patch from #19212 (moved) and saw no crash. But I need to rebuild TBB/ESR45 without the patch and try to reproduce the crash so I know I am doing the test correctly.

added TorBrowserTeam201704R component::applications/tor browser owner::tbb-team parent::20680 priority::medium resolution::fixed severity::normal status::closed type::defect labels

Replying to arthuredelstein:

I reverted the patch from #19212 (moved) and saw no crash. But I need to rebuild TBB/ESR45 without the patch and try to reproduce the crash so I know I am doing the test correctly.

You don't need to rebuild it, Tor Browser 6.0 has the issue. It got fixed in 6.0.1. I just retested an old 6.0 on my machine and I still can reproduce the crash as outlined in #19212 (moved).

Trac:
Parent: N/A to #20680 (moved)

So, like Georg, I was able to reproduce the crash using an earlier version of Tor Browser. I also could reproduce it reverting the #19212 (moved) patch in the latest TBB/ESR45.

But now I realize that in our TBB/ESR52 branch, the game shows an error message: "Failed to download game data!" This message seems to happen, I think, before the crash in the TBB/ESR45 version. So it's possible we're not actually testing the TBB/ESR52 for the crash because some other different is causing the JS to fail. So unfortunately I'm still not sure we can revert the #19212 (moved) patch.

Replying to arthuredelstein:

So, like Georg, I was able to reproduce the crash using an earlier version of Tor Browser. I also could reproduce it reverting the #19212 (moved) patch in the latest TBB/ESR45.

But now I realize that in our TBB/ESR52 branch, the game shows an error message: "Failed to download game data!" This message seems to happen, I think, before the crash in the TBB/ESR45 version.

I don't think so? comment:5:ticket:19212 seems to indicate the opposite if I am reading it right. And comment:7:ticket:19212 seems to indicate that those things are not related at all. If either of those is the case and we are reaching this message without our rebased fix and without a crash then let's get rid of it.

OK, so in TBB/ESR52 with #19212 (moved) reverted, if I set "dom.indexeddb.enabled" to true, then the app seems to work correctly without crashing.

Whereas in TBB/ESR45 with #19212 (moved) reverted, we still get a crash. So I am confident now we can revert #19212 (moved) in TBB/ESR52.

https://github.com/arthuredelstein/tor-browser/commit/21712

Trac:
Status: new to needs_review

Replying to gk:

Replying to arthuredelstein:

So, like Georg, I was able to reproduce the crash using an earlier version of Tor Browser. I also could reproduce it reverting the #19212 (moved) patch in the latest TBB/ESR45.

But now I realize that in our TBB/ESR52 branch, the game shows an error message: "Failed to download game data!" This message seems to happen, I think, before the crash in the TBB/ESR45 version.

I don't think so? comment:5:ticket:19212 seems to indicate the opposite if I am reading it right. And comment:7:ticket:19212 seems to indicate that those things are not related at all. If either of those is the case and we are reaching this message without our rebased fix and without a crash then let's get rid of it.

Yeah, oddly I don't see the "Failed to download game data!" message in TBB/ESR45. Not sure why that is. But my subsequent experiment (comment:5) is also consistent with them being separate issues.

Trac:
Keywords: N/A deleted, TorBrowserTeam201704R added

Thanks, this is ef5d0175d652406190334a77bde5c1ccf492a9a7 on tor-browser-52.0.2esr-7.0-2.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#21712 (closed)