Opened 6 months ago

Closed 6 months ago

#21736 closed defect (fixed)

Do not keep account/timestamp when copy-pasting message containing an URL

Reported by: dgoulet Owned by: huyvq
Priority: Medium Milestone:
Component: Applications/Tor Messenger Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It appears that when copy-pasting a message that contains an URL in a Tor Messenger window, the account and timestamp are taken with it in the "clipboard". Maybe we could not do that or is there a reason?

1:26:15 PM - <nickname>: A message with https://www.google.com

Child Tickets

Change History (7)

comment:1 Changed 6 months ago by arlolra

Are you highlighting the account and timestamp though? From my experience, it only copies what you highlight.

Can you re-check that and confirm?

comment:2 Changed 6 months ago by huyvq

If we select multiple messages (even of the same sender) without selecting the account and timestamp, it will automatically select the account and timestamp.

I think the simplest solution is to make these elements unselectable.

Last edited 6 months ago by huyvq (previous) (diff)

comment:3 Changed 6 months ago by arlolra

I think the simplest solution is to make these elements unselectable.

That's definitely an idea worth exploring.

comment:4 Changed 6 months ago by huyvq

I think the simplest solution is to make these elements unselectable.

It's not. The simplest solution is to change some default message template prefs provided by IB:

messenger.conversations.selections.actionMessagesTemplate
messenger.conversations.selections.contentMessagesTemplate
messenger.conversations.selections.systemMessagesTemplate.

Patch is on its way.

Given that we can change these templates to make timestamp unable to be copied/pasted, should we change "privacy.use_utc_timezone" to false for better UX?
Relate to #17619

Last edited 6 months ago by huyvq (previous) (diff)

comment:5 in reply to:  4 Changed 6 months ago by sukhbir

Replying to huyvq:

I think the simplest solution is to make these elements unselectable.

It's not. The simplest solution is to change some default message template prefs provided by IB:

messenger.conversations.selections.actionMessagesTemplate
messenger.conversations.selections.contentMessagesTemplate
messenger.conversations.selections.systemMessagesTemplate.

(FWIW, we do the same for TorBirdy: https://gitweb.torproject.org/torbirdy.git/tree/components/torbirdy.js#n306)

So yeah, seems like a good idea.

comment:6 Changed 6 months ago by arlolra

Owner: set to huyvq
Status: newassigned
Note: See TracTickets for help on using tickets.