Opened 4 months ago

Closed 4 months ago

#21737 closed defect (fixed)

Speed up keccak-tiny: Use a real load64 function

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points: .1
Parent ID: Points: .1
Reviewer: Sponsor: Sponsor4


The current load-le64 function shows up in keccak profiles. Of course, that's silly. We can do better -- and we do, in other crypto primitives.

Child Tickets

Change History (6)

comment:1 Changed 4 months ago by nickm

  • Owner set to nickm
  • Status changed from new to accepted

comment:2 Changed 4 months ago by nickm

  • Status changed from accepted to needs_review

I see an improvement of about 15% in our sha3 benchmarks with the branch in keccak-load-faster.

comment:3 Changed 4 months ago by yawning

LGTM, make sure to test it on a big endian system?

comment:4 Changed 4 months ago by nickm

I don't have one, but we'll find out when the big-endian arm tests run. Good enuff?

comment:5 Changed 4 months ago by yawning

Probably yeah.

comment:6 Changed 4 months ago by nickm

  • Actual Points set to .1
  • Points set to .1
  • Resolution set to fixed
  • Sponsor set to Sponsor4
  • Status changed from needs_review to closed

Thanks; merging it! Let's see how it goes.

Note: See TracTickets for help on using tickets.