Opened 9 years ago

Closed 9 years ago

Last modified 7 years ago

#2174 closed enhancement (fixed)

Turn on directory request statistics by default

Reported by: karsten Owned by: karsten
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm making progress with combining directory request statistics from multiple relays for estimating daily user numbers. I asked the operators of fast relays to turn on the relevant two config options (DirReqStatistics and ExtraInfoStatistics) to collect these stats and include them in extra-info descriptors. I hope to have results from combining statistics of our fastest relays in two weeks from now. I'm positive that we're going to find some way to combine these statistics.

What is the process for changing the default for all 0.2.3.x and possibly 0.2.2.x relays to turn on directory request statistics by default?

I prepared a patch based on master that changes the defaults. It's branch dirreq-stats-default in my public repository.

Child Tickets

Change History (9)

comment:1 Changed 9 years ago by nickm

I'm fine in principle with this feature for 0.2.3.x, I think.

It's a little worrying that the ExtraInfoStatistics turns on reporting of _all_ recorded statistics, not just DirReqStatistics, but I think all the stats are harmless.

comment:2 in reply to:  1 ; Changed 9 years ago by karsten

Replying to nickm:

I'm fine in principle with this feature for 0.2.3.x, I think.

Great.

It's a little worrying that the ExtraInfoStatistics turns on reporting of _all_ recorded statistics, not just DirReqStatistics, but I think all the stats are harmless.

Yes, I agree.

Okay, I'm going to come back to this in 1 or 2 weeks when I have more results and can say whether changing the default really makes sense.

comment:3 in reply to:  2 Changed 9 years ago by karsten

Status: newneeds_review

Replying to karsten:

Okay, I'm going to come back to this in 1 or 2 weeks when I have more results and can say whether changing the default really makes sense.

I think it makes sense to turn on directory request statistics by default.

Please review branch dirreq-stats-default in my public repository whenever you like.

comment:4 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Hm. I am not I agree with having the logs at level "notice" for not having a geoip file get triggered when people just try to run Tor with the default options. Still, let's try it out and see if it's annoying in practice.

Merged to master.

comment:5 Changed 9 years ago by Sebastian

Resolution: fixed
Status: closedreopened

Hrm, unfortunately this introduces a crash bug when a client connects to an authority without geoip information loaded - we just warn the user that their geoip file is missing but don't actually disable the related statistics. Fix in bug2174 in my repository.

comment:6 Changed 9 years ago by Sebastian

Status: reopenedneeds_review

comment:7 Changed 9 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks ok; merged to master.

comment:8 Changed 7 years ago by nickm

Keywords: tor-relay added

comment:9 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.