Opened 3 years ago

Closed 3 years ago

#21745 closed defect (fixed)

Catch-all circuits are not working properly in ESR 52 based Tor Browser

Reported by: gk Owned by: arthuredelstein
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, tbb-7.0-must, ff52-esr, TorBrowserTeam201703R, tbb-7.0-must-nightly
Cc: brade, mcs Actual Points:
Parent ID: #21201 Points:
Reviewer: Sponsor: Sponsor4

Description

Looking at the console I see often output like

[03-15 07:54:18] Torbutton INFO: tor SOCKS: https://www.torproject.org/projects/torbrowser/RecommendedTBBVersions via :dceca4bdbd10c5b87865edd4fac205eb
[03-15 07:54:18] Torbutton INFO: Failed to get credentials or browser from channel

It seems this is caused by isolateCircuitsByDomain() not throwing anymore if there is no domain to isolate the request to. We should take care of that as that probably breaks our catch-all circuit handling.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by gk

Sponsor: Sponsor4

comment:2 Changed 3 years ago by gk

Note: I get "Torbutton INFO: Failed to get credentials or browser from channel" with the patch in #21547 applied.

comment:3 Changed 3 years ago by arthuredelstein

Owner: changed from tbb-team to arthuredelstein
Status: newassigned

comment:4 Changed 3 years ago by mcs

Cc: brade mcs added

comment:5 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201703R added; TorBrowserTeam201703 removed
Status: assignedneeds_review

comment:6 in reply to:  5 ; Changed 3 years ago by gk

Keywords: TorBrowserTeam201703 added; TorBrowserTeam201703R removed
Status: needs_reviewneeds_revision

Replying to arthuredelstein:

Here's a patch for review:
https://github.com/arthuredelstein/torbutton/commit/21745+1

That breaks the circuit display for me. After applying the patch on top of the other ones in 21201+3 no circuits are shown in the display anymore.

comment:7 in reply to:  6 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201703R added; TorBrowserTeam201703 removed
Status: needs_revisionneeds_review

Replying to gk:

Replying to arthuredelstein:

Here's a patch for review:
https://github.com/arthuredelstein/torbutton/commit/21745+1

That breaks the circuit display for me. After applying the patch on top of the other ones in 21201+3 no circuits are shown in the display anymore.

Phooey. Thanks for catching this mistake. Here's a new version that doesn't break the circuit display.
https://github.com/arthuredelstein/torbutton/commit/21745+2

comment:8 Changed 3 years ago by gk

Keywords: tbb-7.0-must-nightly added

We want those tickets for our first ESR52 nightlies.

comment:9 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me and is commit 1324e306018779166674e9bc6101ddb9e2bbc68b on torbutton master.

Note: See TracTickets for help on using tickets.