Requesting a new circuit for a site is not working in ESR 52 based Tor Browser

Trying to request a new circuit does nothing but instead gives

TypeError: thirdPartyUtil.getFirstPartyHostForIsolation is not a function torbutton.js:1016:26

in the browser console.

added TorBrowserTeam201703R component::applications/tor browser ff52-esr owner::arthuredelstein parent::21201 priority::medium resolution::fixed severity::normal sponsor::4 status::closed tbb-7.0-must tbb-7.0-must-nightly tbb-torbutton type::defect labels

Trac:
Owner: tbb-team to arthuredelstein
Status: new to assigned

Trac:
Cc: N/A to brade, mcs

Here's my patch:

https://github.com/arthuredelstein/torbutton/commit/21747

Trac:
Status: assigned to needs_review

Trac:
Keywords: TorBrowserTeam201703 deleted, TorBrowserTeam201703R added

Replying to arthuredelstein:

Here's my patch:

https://github.com/arthuredelstein/torbutton/commit/21747

That breaks the circuit display for me. After applying the patch on top of the other ones in 21201+3 no circuits are shown in the display anymore.

Trac:
Keywords: TorBrowserTeam201703R deleted, TorBrowserTeam201703 added
Status: needs_review to needs_revision

Replying to gk:

Replying to arthuredelstein:

Here's my patch:

https://github.com/arthuredelstein/torbutton/commit/21747

That breaks the circuit display for me. After applying the patch on top of the other ones in 21201+3 no circuits are shown in the display anymore.

Err, wrong bug.

Trac:
Keywords: TorBrowserTeam201703 deleted, TorBrowserTeam201703R added
Status: needs_revision to needs_review

Here's a new version on top of the updated 21745 patch. https://github.com/arthuredelstein/torbutton/commit/21747+1

We want those tickets for our first ESR52 nightlies.

Trac:
Keywords: N/A deleted, tbb-7.0-must-nightly added

r=brade, r=mcs This patch looks okay and it seems to work. Why did you need to add the following code?

  if (domain === "") {
    domain = "--unknown--";
  }

Replying to mcs:

r=brade, r=mcs This patch looks okay and it seems to work. Why did you need to add the following code? {{{ if (domain === "") { domain = "--unknown--"; } }}}

Thanks for the review. Traditionally we have used "--unknown--" for the catchall domain (and SOCKS username). But for a chrome-initiated request, originAttributes.firstParty is an empty string. So this line ensures that request goes through the "--unknown--" circuit.

Replying to arthuredelstein:

Thanks for the review. Traditionally we have used "--unknown--" for the catchall domain (and SOCKS username). But for a chrome-initiated request, originAttributes.firstParty is an empty string. So this line ensures that request goes through the "--unknown--" circuit.

That makes sense. Thanks!

This is cfa9229fddb79067ebd3a0a6d8d0a10ab1bffc02 on torbutton master, thanks.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#21747 (closed)