Opened 3 years ago

Closed 3 years ago

#21747 closed defect (fixed)

Requesting a new circuit for a site is not working in ESR 52 based Tor Browser

Reported by: gk Owned by: arthuredelstein
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-torbutton, ff52-esr, tbb-7.0-must, TorBrowserTeam201703R, tbb-7.0-must-nightly
Cc: brade, mcs Actual Points:
Parent ID: #21201 Points:
Reviewer: Sponsor: Sponsor4

Description

Trying to request a new circuit does nothing but instead gives

TypeError: thirdPartyUtil.getFirstPartyHostForIsolation is not a function torbutton.js:1016:26

in the browser console.

Child Tickets

Change History (12)

comment:1 Changed 3 years ago by arthuredelstein

Owner: changed from tbb-team to arthuredelstein
Status: newassigned

comment:2 Changed 3 years ago by mcs

Cc: brade mcs added

comment:3 Changed 3 years ago by arthuredelstein

Status: assignedneeds_review

comment:4 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201703R added; TorBrowserTeam201703 removed

comment:5 in reply to:  3 ; Changed 3 years ago by gk

Keywords: TorBrowserTeam201703 added; TorBrowserTeam201703R removed
Status: needs_reviewneeds_revision

Replying to arthuredelstein:

Here's my patch:

https://github.com/arthuredelstein/torbutton/commit/21747

That breaks the circuit display for me. After applying the patch on top of the other ones in 21201+3 no circuits are shown in the display anymore.

comment:6 in reply to:  5 Changed 3 years ago by gk

Keywords: TorBrowserTeam201703R added; TorBrowserTeam201703 removed
Status: needs_revisionneeds_review

Replying to gk:

Replying to arthuredelstein:

Here's my patch:

https://github.com/arthuredelstein/torbutton/commit/21747

That breaks the circuit display for me. After applying the patch on top of the other ones in 21201+3 no circuits are shown in the display anymore.

Err, wrong bug.

comment:7 Changed 3 years ago by arthuredelstein

Here's a new version on top of the updated 21745 patch.
https://github.com/arthuredelstein/torbutton/commit/21747+1

comment:8 Changed 3 years ago by gk

Keywords: tbb-7.0-must-nightly added

We want those tickets for our first ESR52 nightlies.

comment:9 Changed 3 years ago by mcs

r=brade, r=mcs
This patch looks okay and it seems to work. Why did you need to add the following code?

  if (domain === "") {
    domain = "--unknown--";
  }

comment:10 in reply to:  9 ; Changed 3 years ago by arthuredelstein

Replying to mcs:

r=brade, r=mcs
This patch looks okay and it seems to work. Why did you need to add the following code?

  if (domain === "") {
    domain = "--unknown--";
  }

Thanks for the review. Traditionally we have used "--unknown--" for the catchall domain (and SOCKS username). But for a chrome-initiated request, originAttributes.firstParty is an empty string. So this line ensures that request goes through the "--unknown--" circuit.

comment:11 in reply to:  10 Changed 3 years ago by mcs

Replying to arthuredelstein:

Thanks for the review. Traditionally we have used "--unknown--" for the catchall domain (and SOCKS username). But for a chrome-initiated request, originAttributes.firstParty is an empty string. So this line ensures that request goes through the "--unknown--" circuit.

That makes sense. Thanks!

comment:12 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is cfa9229fddb79067ebd3a0a6d8d0a10ab1bffc02 on torbutton master, thanks.

Note: See TracTickets for help on using tickets.