Opened 3 years ago

Closed 3 years ago

#21748 closed defect (fixed)

Snowflake breaks nightly builds as of March 15

Reported by: gk Owned by: arlolra
Priority: High Milestone:
Component: Circumvention/Snowflake Version:
Severity: Major Keywords: tbb-7.0-must-nightly, tbb-gitian, TorBrowserTeam201703R
Cc: dcf, serene Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Our nightly builds are broken now due to Snowflake compilation being unhappy:

+ go install github.com/keroserene/go-webrtc
# github.com/keroserene/go-webrtc
<command-line>:0:0: warning: "_GLIBCXX_USE_CXX11_ABI" redefined
<command-line>:0:0: note: this is the location of the previous definition
# github.com/keroserene/go-webrtc
<command-line>:0:0: warning: "_GLIBCXX_USE_CXX11_ABI" redefined
<command-line>:0:0: note: this is the location of the previous definition
# github.com/keroserene/go-webrtc
<command-line>:0:0: warning: "_GLIBCXX_USE_CXX11_ABI" redefined
<command-line>:0:0: note: this is the location of the previous definition
../../go/src/github.com/keroserene/go-webrtc/peerconnection.cc:13:51: fatal error: webrtc/pc/test/fakeaudiocapturemodule.h: No such file or directory
compilation terminated.

Child Tickets

Attachments (1)

build21748.log (237.4 KB) - added by gk 3 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 Changed 3 years ago by gk

Owner: set to arlolra
Status: newassigned

Assigning to arlo. Let me know if that should be someone else in the future.

comment:2 Changed 3 years ago by arlolra

Yup, this is is because we merged a patch to upgrade webrtc to branch-heads/58 (from 52) in,
https://github.com/keroserene/go-webrtc/pull/61

I'm working on a tor-browser-bundle patch, thanks.

comment:3 Changed 3 years ago by arlolra

Cc: dcf serene added

I have a working branch here,
https://github.com/arlolra/tor-browser-bundle/commits/gn

Just need to get dcf or serene to produce a matching build.

comment:4 Changed 3 years ago by gk

FWIW: We'd need that by next Monday as we want to switch the nightlies to use ESR52 by then.

comment:5 Changed 3 years ago by gk

Keywords: tbb-7.0-must-nightly added

comment:6 Changed 3 years ago by arlolra

gk, to speed things up, could you build the alpha version of the linked branch above?

comment:7 Changed 3 years ago by gk

I'll try, but I need to get our Windows build working with ESR52 first. I'll let you know in this ticket when I have the alpha built hoping someone else does so meanwhile.

comment:8 Changed 3 years ago by gk

I am on fd2b35184753fdef8dcca11040b6416567c9896a and made make prep-alpha and mkbundle-linux.sh versions.alpha. The build fails in step 4/7. The log is attached.

Last edited 3 years ago by gk (previous) (diff)

Changed 3 years ago by gk

Attachment: build21748.log added

comment:9 Changed 3 years ago by arlolra

../../webrtc/base/task_queue_libevent.cc:182:50: error: ignoring return value of 'ssize_t write(int, const void*, size_t)', declared with attribute warn_unused_result [-Werror=unused-result]
3292	     write(reply_pipe_, &message, sizeof(message));

Darn, sorry, I must have removed treat_warnings_as_errors=false :(

comment:10 Changed 3 years ago by arlolra

I just force pushed 121de1ca to the above branch and started a build to confirm.

Sorry for having wasted your time.

comment:11 Changed 3 years ago by gk

Alright, I guess we can parallelize that. I started one as well.

comment:12 Changed 3 years ago by arlolra

That seemed to work. Let's see if you have some matching,

...
d34b4d98accb38c0f9e50178c6f1b473128e8cb51d10199b1afdc0a03041cd50  tor-browser-linux64-7.0a2_ar.mar
4f922462983456bbeca4187d56c04a239e8a65a00e4d6762010bcfa26dc48af1  tor-browser-linux64-7.0a2_ar.tar.xz
93ab3c2b9cf7ba23090a39a6679aeecd923c31714747c8e1ed4cebed101b70fb  tor-browser-linux64-7.0a2_de.mar
752ef758e23970aeff7011269064e07e4921bb4d8e2a19f68ff3b36723abbdda  tor-browser-linux64-7.0a2_de.tar.xz
0bf42106f2ec9d4c2cee689b5c8293449fbb2915c6e52c47e564f8cd7da26c3d  tor-browser-linux64-7.0a2_en-US.mar
1d673966ab4561ac75fde485b0481c0cb128bbda882f284b638949df995412e0  tor-browser-linux64-7.0a2_en-US.tar.xz
...

comment:13 in reply to:  12 Changed 3 years ago by gk

Replying to arlolra:

That seemed to work. Let's see if you have some matching,

...
d34b4d98accb38c0f9e50178c6f1b473128e8cb51d10199b1afdc0a03041cd50  tor-browser-linux64-7.0a2_ar.mar
4f922462983456bbeca4187d56c04a239e8a65a00e4d6762010bcfa26dc48af1  tor-browser-linux64-7.0a2_ar.tar.xz
93ab3c2b9cf7ba23090a39a6679aeecd923c31714747c8e1ed4cebed101b70fb  tor-browser-linux64-7.0a2_de.mar
752ef758e23970aeff7011269064e07e4921bb4d8e2a19f68ff3b36723abbdda  tor-browser-linux64-7.0a2_de.tar.xz
0bf42106f2ec9d4c2cee689b5c8293449fbb2915c6e52c47e564f8cd7da26c3d  tor-browser-linux64-7.0a2_en-US.mar
1d673966ab4561ac75fde485b0481c0cb128bbda882f284b638949df995412e0  tor-browser-linux64-7.0a2_en-US.tar.xz
...

Looks good. Do you have by chance some 32bit SHA256 sums as well? I have

...
6385850447978cde1264fe10fd18dfd5c335ea20fac3f6c874aa969bd9511aad  tor-browser-linux32-7.0a2_ar.mar
50c23f7f628de2849ee52471f8cb9069b32c4238264e95757f28f844abf9f717  tor-browser-linux32-7.0a2_ar.tar.xz
edcbf82362931dfd3a950ff9c6d564ca74c2c0929293551e3124366b2c5dd831  tor-browser-linux32-7.0a2_de.mar
6fdfd3cea6a39c9003ee66900696244ceaa51f64984cb1f67016637c3560d6e6  tor-browser-linux32-7.0a2_de.tar.xz
526f6c81e8c552cecbbb2a00ec7e3adbec2e365773c08ba30b98a7118fdd996a  tor-browser-linux32-7.0a2_en-US.mar
e48d4cd91cf0e64721e44e2c35835cd794e07095cf251e77f5bc21ad29f6af30  tor-browser-linux32-7.0a2_en-US.tar.xz
...

comment:14 Changed 3 years ago by arlolra

Yup, matches.

$ shasum -a 256 tor-browser-linux32-7.0a2_ar.mar 
6385850447978cde1264fe10fd18dfd5c335ea20fac3f6c874aa969bd9511aad  tor-browser-linux32-7.0a2_ar.mar
$ shasum -a 256 tor-browser-linux32-7.0a2_en-US.tar.xz
e48d4cd91cf0e64721e44e2c35835cd794e07095cf251e77f5bc21ad29f6af30  tor-browser-linux32-7.0a2_en-US.tar.xz

comment:15 in reply to:  14 Changed 3 years ago by gk

Replying to arlolra:

Yup, matches.

$ shasum -a 256 tor-browser-linux32-7.0a2_ar.mar 
6385850447978cde1264fe10fd18dfd5c335ea20fac3f6c874aa969bd9511aad  tor-browser-linux32-7.0a2_ar.mar
$ shasum -a 256 tor-browser-linux32-7.0a2_en-US.tar.xz
e48d4cd91cf0e64721e44e2c35835cd794e07095cf251e77f5bc21ad29f6af30  tor-browser-linux32-7.0a2_en-US.tar.xz

Good. Do you feel this is ready for review now?

Last edited 3 years ago by gk (previous) (diff)

comment:16 Changed 3 years ago by arlolra

Do you feel this is ready for review now?

Yes, I do.

comment:17 Changed 3 years ago by gk

Keywords: tbb-gitian TorBrowserTeam201703R added
Status: assignedneeds_review

comment:18 Changed 3 years ago by gk

There is a bunch of Java stuff going away. Do we still need export JAVA_HOME=/usr/lib/jvm/default-java in fetch-inputs.sh?

comment:19 Changed 3 years ago by arlolra

Do we still need export JAVA_HOME=/usr/lib/jvm/default-java in fetch-inputs.sh?

I believe so. It's needed for the calls to gclient there.

comment:20 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Okay, I applied the changes to master (commit 38689af2a845dfa85765bf52e535c89476863378 and 121de1ca7cbee29f34f99753a7948c7447e38965) and hardened-builds (commit 45f6ab2698d447441095e8d388fba3a3aa855f57 and 58801dcbb5d927d6eb35a328cb63d1912434a397). Thanks.

Note: See TracTickets for help on using tickets.