Opened 3 years ago

Closed 3 years ago

#21750 closed task (implemented)

prop224: ntor handshake implementation

Reported by: dgoulet Owned by: asn
Priority: Medium Milestone: Tor: 0.3.1.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-hs, prop224, review-group-17
Cc: Actual Points:
Parent ID: #21888 Points: 6
Reviewer: nickm Sponsor: SponsorR-must

Description

Ticket created after https://trac.torproject.org/projects/tor/ticket/20657#comment:12

Initial reviews are here: https://gitlab.com/asn/tor/merge_requests/13

OK after a review from David and some comments from Nick I present the prop224-ntor-v2 branch which comes with all the code review fixes, and with a full on integration test suite similar to the ./src/test/test_ntor.sh tests for simple ntor.

It also implements the key expansion functionality as requested by David.

Child Tickets

Change History (9)

comment:1 Changed 3 years ago by dgoulet

Keywords: review-group-17 added
Reviewer: nickm
Status: newneeds_review

comment:2 Changed 3 years ago by dgoulet

Parent ID: #20657#21888

We'll try to get this through the high level parent ticket of "laying the groundwork for service implementation".

comment:3 Changed 3 years ago by dgoulet

Ok took over the branch for Gitlab:

tpo branch: prop224-ntor-v2
Gitlab review: https://gitlab.com/dgoulet/tor/merge_requests/21

comment:4 Changed 3 years ago by asn

OK, I pushed a new commit in my prop224-ntor-v2 that parenthesizes the body of some forgotten macros, based on nick's last gitlab review.

Please let me know if there is anything else I can do here.

comment:5 Changed 3 years ago by nickm

thanks asn! My last step here is to go through the python script and the test logic and make sure that they *exactly match* what is in the spec.

comment:6 Changed 3 years ago by nickm

okay, I've left a couple of comments there.

comment:7 Changed 3 years ago by asn

ACK. Pushed another fixup commit to address your latest comments!

comment:8 Changed 3 years ago by asn

Opened #21935 to test the HS ntor subsystem deeper in the future.

comment:9 Changed 3 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

squashing and merging!

Note: See TracTickets for help on using tickets.