Opened 3 years ago

Closed 3 years ago

#21752 closed enhancement (fixed)

put "Current Status" under an Android Browser on top

Reported by: toralf Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Relay Search Version:
Severity: Minor Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Currently it is after "Configuration" and "Properties" but IMO it makes more sense to have this info as a heading.

Child Tickets

Attachments (3)

Change History (13)

comment:1 Changed 3 years ago by dgoulet

Milestone: Tor: 0.3.0.x-final

Atlas doesn't use those "Tor" milestone.

comment:2 in reply to:  description Changed 3 years ago by irl

Status: newneeds_information

Replying to toralf:

Currently it is after "Configuration" and "Properties" but IMO it makes more sense to have this info as a heading.

Is it the uptime or the "running" status that you're interested in?

Maybe we can add a red/green light next to the relay nickname heading to indicate running status and this will fix this for you?

comment:3 Changed 3 years ago by toralf

yes, that would be fully ok - the idea behind this trac record is just getting the main info on top and teh detailed numbers below it.

comment:4 Changed 3 years ago by cypherpunks

Status: needs_informationneeds_review

Patch 0001 addresses the main idea behind this ticket. Patch 0002 and 0003 merge the current status and properties columns and reverts some new styling respectively. I've intentionally split the changes up in separate commits so the changes can be picked up selectively. For reasoning of the changes see the commit messages.

comment:5 Changed 3 years ago by irl

Resolution: fixed
Status: needs_reviewclosed

Ok, I've merged the first and second patches. On tiny screens there can still be wrapping of the fingerprint (thinking mobile devices and ridiculous smart watches for the relay operator on the go) so I don't see the harm in not merging that one.

Thanks for your work. Feel free to reopen the ticket if you feel strongly on the third patch.

comment:6 Changed 3 years ago by cypherpunks

Resolution: fixed
Status: closedreopened

I believe the third patch should be merged for the following reasons.

With a resolution of 360x640 the fingerprint isn't wrapped either with or without the patch. with a resolution of 320x480 the fingerprint is wrapped by two chars without the patch and by four chars with the patch which IMO isn't a big deal. This was tested in responsive design mode with Tor Browser.

The patch reverts the margins back to the default which fits more text on the screen. This is actually better for tiny screens.

Lastly, it removes code and less code is easier to maintain.

comment:7 Changed 3 years ago by cypherpunks

See ticket:22160#comment:1 for an instance where the custom styling prevents an easy solution from being used.

comment:8 Changed 3 years ago by irl

Status: reopenedneeds_review

comment:9 Changed 3 years ago by irl

Note to self: #22160 would benefit from this.

comment:10 Changed 3 years ago by irl

Resolution: fixed
Status: needs_reviewclosed

Ok, merged. Seems OK in Firefox and Tor Browser at least. We'll see if we get any complaints from mobile users.

Note: See TracTickets for help on using tickets.