Get rid of old GCC toolchain in pluggable transports macOS descriptor

The pluggable transports descriptor is the last place using the old GCC based toolchain for OS X cross-compilation (now that we have a patch for #10369 (moved)). Time to get rid of it as well.

added GeorgKoppen201703 TorBrowserTeam21703R component::applications/tor browser owner::tbb-team parent::21328 priority::medium resolution::fixed severity::normal status::closed tbb-gitian type::defect labels

Trac:
Keywords: N/A deleted, tbb-gitian added

bug_21753_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21753_v3&id=d0465e4ce9e9fa13a46faae8c7401b5fb78582f8) in my public tor-browser-bundle repo has a fix for this bug.

dcf: you might find this interesing while testing the switch to Go 1.7.5 and 1.8. (If you have feedback regarding that patch I am all ears; I have not been doing much work in the Go cross-compiling area so far).

Trac:
Keywords: TorBrowserTeam21703 deleted, TorBrowserTeam21703R added
Status: new to needs_review
Cc: N/A to dcf

Replying to gk:

dcf: you might find this interesing while testing the switch to Go 1.7.5 and 1.8. (If you have feedback regarding that patch I am all ears; I have not been doing much work in the Go cross-compiling area so far).

I will test rebasing the 1.7.5 patch on top of bug_21753_v3.

However, make prep is failing for me on the bug_21753_v3 branch:

--2017-03-19 12:37:08--  https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/45.2.0esr-candidates/build2/linux-i686/xpi/ar.xpi
Resolving ftp.mozilla.org (ftp.mozilla.org)... 54.230.140.70
Connecting to ftp.mozilla.org (ftp.mozilla.org)|54.230.140.70|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-03-19 12:37:09 ERROR 404: Not Found.

Makefile:93: recipe for target 'prep' failed
make: *** [prep] Error 8

Replying to dcf:

However, make prep is failing for me on the bug_21753_v3 branch: {{{ --2017-03-19 12:37:08-- https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/45.2.0esr-candidates/build2/linux-i686/xpi/ar.xpi Resolving ftp.mozilla.org (ftp.mozilla.org)... 54.230.140.70 Connecting to ftp.mozilla.org (ftp.mozilla.org)|54.230.140.70|:443... connected. HTTP request sent, awaiting response... 404 Not Found 2017-03-19 12:37:09 ERROR 404: Not Found.

Makefile:93: recipe for target 'prep' failed make: *** [prep] Error 8 }}}

Yeah, the stable target does seldom work on master, we have usually the maint- branches for that. Doing nightly builds is busted right now due to #21748 (moved) and PTs aren't working in nightly builds either (#21757 (moved)). Thus, your best bet is probably using make prep-alpha and doing an alpha build and test that one.

Replying to gk:

Yeah, the stable target does seldom work on master, we have usually the maint- branches for that. Doing nightly builds is busted right now due to #21748 (moved) and PTs aren't working in nightly builds either (#21757 (moved)). Thus, your best bet is probably using make prep-alpha and doing an alpha build and test that one.

I see. I may not be able to test this soon, then. I haven't been able to build new base VM images on Debian for a while now. I think it is still this old issue: https://lists.torproject.org/pipermail/tbb-dev/2016-April/000371.html. I will have to apply the workaround of building new base VM images on Ubuntu and copying them to Debian, and I don't have an Ubuntu set up right now.

Replying to gk:

bug_21753_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21753_v3&id=d0465e4ce9e9fa13a46faae8c7401b5fb78582f8) in my public tor-browser-bundle repo has a fix for this bug.

This patch looks good to me.

This is commit 2fe7170ac1f07b051fa69183b7dc852a62d4f9be on master.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #21754 (moved)

mentioned in issue #21757 (moved)

mentioned in issue #21913 (moved)

mentioned in issue tpo/core/tor#21757 (closed)

moved to tpo/applications/tor-browser#21753 (closed)

mentioned in issue tpo/applications/tor-browser#21913 (closed)