Opened 3 years ago

Closed 2 years ago

#21753 closed defect (fixed)

Get rid of old GCC toolchain in pluggable transports macOS descriptor

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam21703R, GeorgKoppen201703, tbb-gitian
Cc: dcf Actual Points:
Parent ID: #21328 Points:
Reviewer: Sponsor:

Description

The pluggable transports descriptor is the last place using the old GCC based toolchain for OS X cross-compilation (now that we have a patch for #10369). Time to get rid of it as well.

Child Tickets

Change History (8)

comment:1 Changed 3 years ago by gk

Keywords: tbb-gitian added

comment:2 Changed 3 years ago by gk

Cc: dcf added
Keywords: TorBrowserTeam21703R added; TorBrowserTeam21703 removed
Status: newneeds_review

bug_21753_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21753_v3&id=d0465e4ce9e9fa13a46faae8c7401b5fb78582f8) in my public tor-browser-bundle repo has a fix for this bug.

dcf: you might find this interesing while testing the switch to Go 1.7.5 and 1.8. (If you have feedback regarding that patch I am all ears; I have not been doing much work in the Go cross-compiling area so far).

comment:3 in reply to:  2 Changed 3 years ago by dcf

Replying to gk:

dcf: you might find this interesing while testing the switch to Go 1.7.5 and 1.8. (If you have feedback regarding that patch I am all ears; I have not been doing much work in the Go cross-compiling area so far).

I will test rebasing the 1.7.5 patch on top of bug_21753_v3.

comment:4 Changed 3 years ago by dcf

However, make prep is failing for me on the bug_21753_v3 branch:

--2017-03-19 12:37:08--  https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/45.2.0esr-candidates/build2/linux-i686/xpi/ar.xpi
Resolving ftp.mozilla.org (ftp.mozilla.org)... 54.230.140.70
Connecting to ftp.mozilla.org (ftp.mozilla.org)|54.230.140.70|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-03-19 12:37:09 ERROR 404: Not Found.

Makefile:93: recipe for target 'prep' failed
make: *** [prep] Error 8

comment:5 in reply to:  4 ; Changed 3 years ago by gk

Replying to dcf:

However, make prep is failing for me on the bug_21753_v3 branch:

--2017-03-19 12:37:08--  https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/45.2.0esr-candidates/build2/linux-i686/xpi/ar.xpi
Resolving ftp.mozilla.org (ftp.mozilla.org)... 54.230.140.70
Connecting to ftp.mozilla.org (ftp.mozilla.org)|54.230.140.70|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-03-19 12:37:09 ERROR 404: Not Found.

Makefile:93: recipe for target 'prep' failed
make: *** [prep] Error 8

Yeah, the stable target does seldom work on master, we have usually the maint- branches for that. Doing nightly builds is busted right now due to #21748 and PTs aren't working in nightly builds either (#21757). Thus, your best bet is probably using make prep-alpha and doing an alpha build and test that one.

comment:6 in reply to:  5 Changed 3 years ago by dcf

Replying to gk:

Yeah, the stable target does seldom work on master, we have usually the maint- branches for that. Doing nightly builds is busted right now due to #21748 and PTs aren't working in nightly builds either (#21757). Thus, your best bet is probably using make prep-alpha and doing an alpha build and test that one.

I see. I may not be able to test this soon, then. I haven't been able to build new base VM images on Debian for a while now. I think it is still this old issue: https://lists.torproject.org/pipermail/tbb-dev/2016-April/000371.html. I will have to apply the workaround of building new base VM images on Ubuntu and copying them to Debian, and I don't have an Ubuntu set up right now.

comment:7 in reply to:  2 Changed 2 years ago by boklm

Replying to gk:

bug_21753_v3 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_21753_v3&id=d0465e4ce9e9fa13a46faae8c7401b5fb78582f8) in my public tor-browser-bundle repo has a fix for this bug.

This patch looks good to me.

comment:8 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is commit 2fe7170ac1f07b051fa69183b7dc852a62d4f9be on master.

Note: See TracTickets for help on using tickets.