Opened 3 years ago

Closed 4 weeks ago

#2176 closed defect (invalid)

Branding of TBB

Reported by: ioerror Owned by: erinn
Priority: major Milestone:
Component: Tor bundles/installation Version:
Keywords: Bounty, tbb-branding Cc: helix, gk, peter@…, adrelanos@…
Actual Points: Parent ID:
Points:

Description

I think we should have a consistent branding of TBB across all platforms and releases.

There are two major issues relating to having consistent branding:

  1. Firefox has nice icons/branding and some users understand them to be The Internet.
  2. We may visually identify ourselves as the Tor Browser Bundle and thus a user may be detected as using Tor.

Generally speaking, I think that the first issue causes us problems on a number of levels. The most obvious is that a user may have multiple icons that look like Firefox - which one provides anonymity? In some cases, we simply don't brand as Firefox (Linux); it's not clear how a user will be trained in a cross platform way from a branding standpoint. The UX issues here seem to largely come from users not knowing what Tor does and does not do for them.

I'm a bit concerned that the second issue is a losing issue all around. We ship Vidalia with an icon that is obviously Tor related.

Another issue is related to trademarks; someday, someone from somewhere is gonna be pissed. I think we should be ready in advance, even if it's with crappy icons or slightly crappy branding.

Child Tickets

Attachments (1)

aurora.tar.gz (1.3 MB) - added by ioerror 3 years ago.

Download all attachments as: .zip

Change History (46)

comment:1 Changed 3 years ago by phobos

If someone wants to create a firefox persona for tor, great. I encourage them to put it in the firefox persona site and convince others to use it.

This topic of a custom branded firefox in tbb comes up every so often. When mentioning it to people that really need tbb in hostile places, they look at me in horror. The forced homepage of check.tpo is bad enough, making firefox scream, "I AM USING TOR PLEASE LOOK AT ME CLOSELY" isn't conducive to keeping them out of trouble.

Perhaps we have a firefox persona that's shipped with tbb, but disabled by default. If users are confused, they can enable it when they feel safe.

comment:3 Changed 3 years ago by bee

Hi phobos!!!!!!!!!!!!!!!!
In my tor browser bundle for linux, factorbee, i decided to don't use personas!!!!! because they're so very ugly!!!!!!!!!!! and i don't like them!!!!!
I think that also mikeperry's browser bundle should not use personas!!!!!! they look badly everywhere!!!!!!!!

"a user may have multiple icons that look like Firefox - which one provides anonymity?"
In factorbee i changed the taskbar icon!!!!!!!!!! in this old screenshot the taskbar is visible http://honeybeenet.altervista.org/factorbee/images/screenshots/4.png YEAH!!!!!!!! It's very easy to recognize the right windows of firefox in this way!!!!!!! and the icon is small not so much visible like personas!!! YEAH!!!! and it's even much more nice!!!!!!!!! super!!!!!!!!
Personas were a very bad idea!!!!!!!! they're yet another reason why firefox is bloated of useless stuffs!!!!!! Googlezilla put a lot of efforts into the sabotage of firefox to turn it into a bloatware!!!!!!!
I like the taskbar icon, because it's possible to recognize the windows of FactorBee even if you don't "restore" the minimized windows!!!!!!!!!!! YEAH!!!! With personas you'd to look at all windows before finding the right one!!! and at the same time you're forced to live with a persona when you're using the tor-bundle!!! Yeah that ugly way to have firefox themes!!!!!!!!!!!! makes the Net surfing annoying!!!!!!!!!!!
The taskbar icon is another reason why Factorbee is the very best TOR Browser bundle!!!!!!!!!!!!!!!!!!!!!!!! YEAH!!!!!!!!!!!!!!!!!!!

bye!!!!!!!!!!!!!!
~bee!!!!!!!!

comment:4 Changed 3 years ago by mikeperry

  • Keywords Bounty added; tbb removed

comment:5 follow-up: Changed 3 years ago by phobos

so countering my own concerns from last year, after handling many support questions, #1 is "what is aurora?". People frequently start tor browser, close aurora, start their normal browser, and assume it's safe. Some sort of branding or a simple rename of aurora to TorBrowser or something may make it better. Maybe a persona. Maybe the new tor check will help people understand what the browser is for.

comment:6 in reply to: ↑ 5 Changed 3 years ago by arma

Replying to phobos:

so countering my own concerns from last year, after handling many support questions, #1 is "what is aurora?". People frequently start tor browser, close aurora, start their normal browser, and assume it's safe. Some sort of branding or a simple rename of aurora to TorBrowser or something may make it better. Maybe a persona. Maybe the new tor check will help people understand what the browser is for.

I also think fixing the name issue is important. I don't think a new check.tp.o page can fix it -- even once TBB has started, people don't realize that "Aurora" is the tab that their TBB is in, so they move to another window and then can't find their TBB anymore.

What name do we want? I think naming it Firefox will mean users can't tell which window is the TBB window. Does that leave 'Tor Browser'?

comment:7 Changed 3 years ago by erinn

I think Tor Browser is the way to go, probably with a proper little logo we can use as the icon. I'm not sure what the icon should be -- I think Jeremy had a design for a Tor Browser Bundle icon a while ago which seems like a good option (we don't want another onion, in addition to the Vidalia icon), and we should probably talk to him about putting the theme together. It should be easy for me to add it to the build scripts once it exists.

comment:8 Changed 3 years ago by erinn

What do people think about me going ahead and changing the name prior to us getting any artwork/personas/icons though? Are there any downsides to that?

comment:9 Changed 3 years ago by arma

Works for me. I think the main places we need to change it are the title bar on the browser window, and whatever the little window is called when you alt-tab to it.

Come to think of it, does that second case show a name and a logo, or just a logo, on Windows?

comment:10 Changed 3 years ago by phobos

I think just calling it "Tor Browser" is good enough for now. It will at least identify it to users.

comment:11 Changed 3 years ago by phobos

In Tor Browser 0.2.2.33-3, the browser is called "Firefox", I think that's a trademark violation since we patch and modify the browser. I vote for "Tor Browser" as the name of the browser until we derive a better name.

comment:12 Changed 3 years ago by phobos

For tbb-0.2.2.33-3, in linux, it's still called aurora, in os x it's called Firefox. odd.

comment:13 Changed 3 years ago by ioerror

So a few years ago I wrote torbrowser/build-scripts/branding/* that is currently in git://git.torproject.org/torbrowser.git

Has anyone tried this lately? A lot has changed but I believe it was really on the level back in the day.

comment:14 Changed 3 years ago by ioerror

I tried to build TBB for linux to find out if my old patch was still relevant and I found that it wasn't straight forward. What's the right place to find docs on how to do that for Linux TBB?

comment:15 Changed 3 years ago by erinn

Right now the linux.mk in maint-2.2 is the only documentation on building the Linux TBB. The versions are in versions.mk along with some generalized makefile targets for unpacking tarballs, etc. There's a build-firefox target in linux.mk that is probably closer to what you really want to know; in theory you should be able to put the firefox-torbrowser.diff into torbrowser.git/src/current-patches and rename it in a way the makefile expects (000*patch) and just make -f linux.mk build-firefox.

comment:16 Changed 3 years ago by ioerror

Hi Erinn,

make -f linux.mk build-firefox
# XXX: add directions ASAP

That can't be right, right? So the master torbrowser.git isn't actually the main repo anymore? Is maint-2.2 in the torbrowser.git repo the right maint-2.2?

comment:17 Changed 3 years ago by ioerror

OK, I see that the file is in maint-2.2 of the torbrowser.git repo; I'll try that, I suspect my patch won't quite work without changes.

comment:18 Changed 3 years ago by ioerror

I did the following:

git clone -b maint-2.2 git://git.torproject.org/torbrowser.git
make -f linux.mk source-dance

I had the following error:

libpng-1.4.8/projects/vstudio/zlib/zlib.vcxproj
libpng-1.4.8/projects/vstudio/pngtest/pngtest.vcxproj
make: *** No rule to make target `unpack-qt', needed by `unpack-source'.  Stop.

comment:19 Changed 3 years ago by ioerror

I found that I needed to manually unpack the rest of the source - this is probably a good makefile target to add:

cd $SRC_DIR
for file in `ls -1|grep .bz2`; do tar -xvzf $file; done
for file in `ls -1|grep .bz2`; do tar -xvjf $file; done

comment:20 follow-up: Changed 3 years ago by ioerror

I wonder if it might make sense also to have a build-deps target?

I had to install the following package on Ubuntu (maverick):

libgtk2.0-dev
libnotify-dev
yasm
libasound2-dev
libcurl4-openssl-dev
libidl-dev
libiw-dev
libxt-dev
mesa-common-dev

It seems odd to me that we don't do stuff like "--disable-necko-wifi" at build time. Why do we need WebGL and Wifi Scanning? Is this just an oversight with this build target?

What other packages are needed? The above is just for Firefox (!) and not the full TBB.

comment:21 Changed 3 years ago by ioerror

After installing the above packages (who knows what I had installed to start with, wheeeeeee!) and unpacking the sources manually, I've got a Firefox building in the background.

Now I'll work on updating my patch and see if it is possible to re-brand this sucker.

comment:22 in reply to: ↑ 20 ; follow-up: Changed 3 years ago by mikeperry

Replying to ioerror:

I wonder if it might make sense also to have a build-deps target?

It seems odd to me that we don't do stuff like "--disable-necko-wifi" at build time. Why do we need WebGL and Wifi Scanning? Is this just an oversight with this build target?

We disable this stuff via about:config prefs. In general, disabling components via multiple mechanisms just makes things harder for us later, if/when we enable them..

comment:23 Changed 3 years ago by ioerror

This seems hilarious but perhaps we can just rebrand by using this XPI?

https://addons.mozilla.org/en-US/firefox/addon/rebrand/

comment:24 in reply to: ↑ 22 Changed 3 years ago by ioerror

Replying to mikeperry:

Replying to ioerror:

I wonder if it might make sense also to have a build-deps target?

It seems odd to me that we don't do stuff like "--disable-necko-wifi" at build time. Why do we need WebGL and Wifi Scanning? Is this just an oversight with this build target?

We disable this stuff via about:config prefs. In general, disabling components via multiple mechanisms just makes things harder for us later, if/when we enable them..

Wait - what? You're kidding - right? We should not compile in this code if we don't use it. It's not only dead code, it's vulnerable code just waiting for a call from a ROP payload.

comment:25 Changed 3 years ago by ioerror

Ok, after a few missteps, I made the simplest patch possible:

git diff
diff --git a/build-scripts/linux.mk b/build-scripts/linux.mk
index 76949f5..ea76434 100644
--- a/build-scripts/linux.mk
+++ b/build-scripts/linux.mk
@@ -40,7 +40,7 @@ BUILD_NUM=3
 PLATFORM=Linux
 
 ## Location of directory for source unpacking
-FETCH_DIR=/srv/build-trees/build-alpha-$(ARCH_TYPE)
+FETCH_DIR=/tmp/srv/build-trees/build-alpha-$(ARCH_TYPE)
 ## Location of directory for prefix/destdir/compiles/etc
 BUILT_DIR=$(FETCH_DIR)/built
 TBB_FINAL=$(BUILT_DIR)/TBBL
@@ -116,6 +116,9 @@ build-firefox:
        cp patch-firefox-src.sh $(FIREFOX_DIR)
        cp $(CONFIG_SRC)/dot_mozconfig $(FIREFOX_DIR)/mozconfig
        cd $(FIREFOX_DIR) && ./patch-firefox-src.sh
+## Rebrand by passing in a totally different aurora directory
+       rm -r $(FIREFOX_DIR)/browser/branding/aurora/
+       cp -arv branding/aurora $(FIREFOX_DIR)/browser/branding
        cd $(FIREFOX_DIR) && make -f client.mk build
 
 copy-firefox:

This requires that you add branding/aurora to our branding directory. I've made an aurora.tar.gz - if you unpack it into torbrowser/branding/aurora and apply the patch above, you'll have a re-branded Firefox, I believe. It's pretty ghetto but it's a good start.

Changed 3 years ago by ioerror

comment:26 Changed 3 years ago by ioerror

All of the images in aurora.tar.gz need to be changed and eventually, we should make a new directory called torbrowser - then we can just select it as the brand. However as of now, we're making the minimal change because it is the easiest.

comment:27 Changed 3 years ago by ioerror

Also, we could use --with-branding=dir later down the road, once we have a directory we're happy with...

comment:28 Changed 3 years ago by ioerror

I've opened another bug about the code bloat and security related concerns in #4280

comment:29 Changed 3 years ago by ioerror

Ok, I tested this branding stuff and indeed, I found that it works as expected. So the three line changes (and the tar.gz) above are good to merge, I think.

comment:31 Changed 3 years ago by gk

  • Cc g.koppen@… added

comment:32 Changed 2 years ago by phobos

Where are we at on this? Quickly becoming the #1 question for support is "what is Aurora?" I'm not sure if we need to update the docs, change the name of aurora, or both. Or fourthly, when vidalia starts, have it set a pop-up on first run that says "starting the tor browser, codenamed aurora, please wait" or something to tell the user that aurora is what we call tor browser.

comment:33 Changed 2 years ago by erinn

It's partially implemented. I'll bump its priority.

comment:34 in reply to: ↑ description Changed 2 years ago by zephalis

Replying to ioerror:

I think we should have a consistent branding of TBB across all platforms and releases.

There are two major issues relating to having consistent branding:

  1. Firefox has nice icons/branding and some users understand them to be The Internet.
  2. We may visually identify ourselves as the Tor Browser Bundle and thus a user may be detected as using Tor.

Generally speaking, I think that the first issue causes us problems on a number of levels. The most obvious is that a user may have multiple icons that look like Firefox - which one provides anonymity? In some cases, we simply don't brand as Firefox (Linux); it's not clear how a user will be trained in a cross platform way from a branding standpoint. The UX issues here seem to largely come from users not knowing what Tor does and does not do for them.

I'm a bit concerned that the second issue is a losing issue all around. We ship Vidalia with an icon that is obviously Tor related.

Another issue is related to trademarks; someday, someone from somewhere is gonna be pissed. I think we should be ready in advance, even if it's with crappy icons or slightly crappy branding.

I'm new to Tor in general and I myself was wondering about the branding of the browser and had the concern about the difference from a normal FF build chain. I wanted to make the suggestion that the browser should show the user at all times what the outward branding is and possibly the ability to actively change it on a per page basis. As for the user-side branding, it is vital that it exist but can be turned off. Also info on what IP/country/browser you appear to be from somewhere would be a help [imagine you accidentally appear to be in the same country you're trying to avoid]. This would improve the feel of the browser and make it it's own entity.

Something as simple as a logo that reflects Tor and the browser itself, while resisting ties to the Mozilla (in case other browsers become an option in the bundle like Opera or Chrome. If the pages are protected (as in a case of a future option to change individual tabs), then a modified icon that would clearly notify the user that the tab is protected would be nice.

I hope I'm not out of line putting this here but the Mozilla Project had the same issues, reflected in Steven Garrity's suggestions to the Mozilla Foundation back before FF2.

Branding is important for recognition but should also be maskable given the nature of potential uses of Tor and the TBB.

comment:35 Changed 2 years ago by mikeperry

  • Milestone set to TorBrowserBundle 2.2.x-stable
  • Priority changed from normal to major
  • Type changed from enhancement to defect

Bug #4774 suggests we look at the Palemoon branding for tips: http://www.palemoon.org/technical.shtml

Also, now that Tor Browser is calling itself Firefox, this is issue is now a major bug. Our users are getting confused :/.

comment:36 Changed 2 years ago by phobos

Another bump to prioritize figuring this out, even if it means ugly hacks and sed -i -e 's/firefox/torbrowser/i' of the source code. Erinn knows this is coming after our conversation yesterday.

comment:37 Changed 2 years ago by reuteras

  • Cc peter@… added

comment:38 follow-up: Changed 2 years ago by joebt

Mike's link to Palemoon, about using Firefox branding (for TBB) is an issue I raised some time ago, but no answer. Thought it might be a mistake for those in repressive countries to "raise a big red flag" that they are using TBB, maybe something could be worked out. Maybe to avoid problems down the road, Tor Project could get written permission to use the Firefox logo (maybe w/ a hint of difference?, that no one would notice, just passing by).

As for those that find the logos being the same a time waster, especially on the open apps tab in task bar, maybe a simple theme / addon could be made available to change the browser menu button color / name & also the logo on an open app tab in task bar. The color of the main menu button & the text displayed is a simple change, via useChrome.css.  I haven't figured how to change the logo in the open app tab in task bar.

/* This changes color of orange Firefox menu button. */

*

#appmenu-button {
background: #008000 !important;
}

*

/* This changes the appmenu-button text from "Firefox" to "Torbrow"*/

*

#appmenu-button dropmarker:before {
content: "TorBrow" !important;
}
#appmenu-button .button-text {
display: none !important;

comment:39 in reply to: ↑ 38 Changed 2 years ago by joebt

Replying to joebt:

"Thought it might be a mistake for those in repressive countries "

Should read, "Though it might..."

comment:40 Changed 2 years ago by erinn

We got some icons from our graphic designer Jeremy recently and I've tested them on OSX. They look great and after a little more testing I think this will be in the next TBB release.

comment:41 Changed 2 years ago by erinn

  • Resolution set to fixed
  • Status changed from new to closed

This is fixed in the pending TBBs, to be uploaded today. Closing.

comment:42 Changed 17 months ago by proper

  • Cc adrelanos@… added
  • Resolution fixed deleted
  • Status changed from closed to reopened

When you click on Help -> About TorBrowser you'll still see a giant Firefox logo, Firefix ESR and "Firefox and Firefox logos are...".

comment:43 Changed 2 months ago by cypherpunks

There is also a Firefox logo in "about:" and "about:logo" (#10888)

comment:44 Changed 2 months ago by gk

  • Cc gk added; g.koppen@… removed
  • Keywords tbb-branding added
  • Milestone TorBrowserBundle 2.2.x-stable deleted

comment:45 Changed 4 weeks ago by mikeperry

  • Resolution set to invalid
  • Status changed from reopened to closed

This bug is ancient and is muddled with numerous branding issues that existed back in the Vidalia days that have since been solved. Closing this as invalid. There are of course a few specific branding issues that still exist in TBB 3.x (https://trac.torproject.org/projects/tor/query?keywords=~tbb-branding&status=!closed), and this is not a dismissal of those remaining issues.

Note: See TracTickets for help on using tickets.