Opened 22 months ago

Last modified 5 months ago

#21762 reopened defect

Check new Firefox favicon code for first-party isolation

Reported by: arthuredelstein Owned by: arthuredelstein
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff52-esr, TorBrowserTeam201705, tbb-7.0-must
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor: Sponsor4

Description

mcs and brade noticed some new favicon patches in Firefox that we should check for first-party isolation, and patch if FPI is violated:

https://bugzilla.mozilla.org/show_bug.cgi?id=530999
https://bugzilla.mozilla.org/show_bug.cgi?id=1184739
https://bugzilla.mozilla.org/show_bug.cgi?id=1206560

Child Tickets

Change History (16)

comment:1 Changed 22 months ago by gk

Keywords: ff52-esr added; tbb-52esr removed

comment:2 Changed 22 months ago by gk

Sponsor: Sponsor4

comment:3 Changed 21 months ago by gk

Keywords: tbb-7.0-must added

Adding tickets to our 7.0 ticket list

comment:4 Changed 21 months ago by cypherpunks

In Page Info

[...] Torbutton INFO: tor SOCKS: https://trac.torproject.org/images/favicon.ico via --unknown--:8cb660b4e3a184328e50ad46b98d88ec

comment:5 Changed 21 months ago by gk

Keywords: tbb-7.0-must-alpha added; tbb-7.0-must removed

Moving tickets onto our alpha radar.

comment:6 Changed 21 months ago by gk

Keywords: TorBrowserTeam201705 added
Priority: MediumHigh

comment:7 Changed 21 months ago by arthuredelstein

Owner: changed from tbb-team to arthuredelstein
Status: newaccepted

comment:8 Changed 20 months ago by gk

Keywords: tbb-7.0-must added; tbb-7.0-must-alpha removed

We are beyond the alpha testing. Moving tickets for tbb-7.0-must.

comment:9 in reply to:  4 Changed 20 months ago by arthuredelstein

Replying to cypherpunks:

In Page Info

[...] Torbutton INFO: tor SOCKS: https://trac.torproject.org/images/favicon.ico via --unknown--:8cb660b4e3a184328e50ad46b98d88ec

I opened #22327 for this issue.

comment:10 Changed 20 months ago by gk

We need a new patch for the issue fixed in #16983 it seems.

comment:11 in reply to:  10 Changed 20 months ago by arthuredelstein

Replying to gk:

We need a new patch for the issue fixed in #16983 it seems.

I opened #22452 for this issue.

comment:12 Changed 20 months ago by gk

Do we have things left to do in this ticket?

comment:13 Changed 20 months ago by gk

Resolution: fixed
Status: acceptedclosed

Added to tor-browser-52.1.0esr-7.0-2 as commit 1cb4d06b54d26e35c78b398abdd456444b26acd7 and to tor-browser-52.1.1esr-7.0-1 as commit 93469df805f4001dc837299bc3076855d7bff6ae.

comment:14 Changed 20 months ago by gk

Resolution: fixed
Status: closedreopened

Err, wrong ticket.

comment:15 Changed 5 months ago by ct

Did you check items in favicons database on disk in esr60?

comment:16 Changed 5 months ago by gk

Cc: tbb-team added
Note: See TracTickets for help on using tickets.