Changes between Initial Version and Version 1 of Ticket #21766, comment 30


Ignore:
Timestamp:
May 17, 2017, 12:23:22 AM (2 years ago)
Author:
arthuredelstein
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21766, comment 30

    initial v1  
    22> see ticket:21886#comment:16 for a patch that tries but fails to fix this problem.
    33
    4 I cherry-picked this patch onto `tor-browser-52.1.1esr-7.0-1-build1` (`454a231f2b76a8857748d93f666bb93199f4b963`), built tor-browser.git, and added NoScript and torbutton. The patch worked for me (with e10s active) -- I saw the confirmation prompt and was able to cancel or download files. I used gdb to check the return values of Suspend() and Resume() and they both returned NS_OK.
     4I cherry-picked this patch onto `tor-browser-52.1.1esr-7.0-1-build1` (`454a231f2b76a8857748d93f666bb93199f4b963`), built tor-browser.git, and added NoScript and torbutton. The patch worked for me (with e10s active) -- I saw the confirmation prompt and was able to cancel or download files on Linux. I used gdb to check the return values of Suspend() and Resume() and they both returned NS_OK.
    55
    66So I'm wondering if something might have been patched in the latest version of 52ESR? I haven't checked on Windows yet but it seems like this patch might actually be OK.